Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable serial usart timeout #11057

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Configurable serial usart timeout #11057

merged 1 commit into from
Nov 29, 2020

Conversation

XScorpion2
Copy link
Contributor

@XScorpion2 XScorpion2 commented Nov 28, 2020 •
edited
Loading

Description

Added an option to allow overriding the serial usart timeout. Reducing this on a STM32F303CC Split has shown a noticeable improvement on keyboard startup speed as well as a very small improvement on matrix scan speed. Going from 100ms to 10ms made it startup significantly faster (sadly didn't time it), and the scan speed improved by ~50 scans per second.

Recreation of PR: #11013

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 9414be3 into qmk:develop Nov 29, 2020
@zvecr
Copy link
Member

zvecr commented Nov 29, 2020

Thanks!

@XScorpion2 XScorpion2 deleted the config_serial_timeout branch November 29, 2020 16:34
noroadsleft pushed a commit that referenced this pull request Nov 30, 2020
@XScorpion2 @noroadsleft
Configurable serial usart timeout (#11057)
990d518
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Dec 16, 2020
@nicsuzor
Merge remote-tracking branch 'XScorpion2/split_rgb_matrix_2020'
c84595c 
* XScorpion2/split_rgb_matrix_2020:
  Split RGB Matrix
  Split transport mirror support
  [Split] Sync Timer feature (qmk#10997)
  Branch point for 2021 Feb 27 Breaking Change
  Configurable serial usart timeout (qmk#11057)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@XScorpion2 @noroadsleft
Configurable serial usart timeout (qmk#11057)
a91a3f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XScorpion2 @zvecr @drashna