Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for POINTING_DEVICE_DRIVER #11075

Closed
wants to merge 10 commits into from
Closed

Add support for POINTING_DEVICE_DRIVER #11075

wants to merge 10 commits into from

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 30, 2020

Description

Like the title says... and some cleanup.

Types of Changes

  • Core
  • New feature
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 30, 2020 04:55
@drashna
Copy link
Member Author

drashna commented Nov 30, 2020

Creating as a draft for now, since I'd like to add the pmw3389 sensor, as well.

@drashna drashna force-pushed the driver/optical_sensors branch 2 times, most recently from ddb623c to 7aa34ee Compare December 19, 2020 19:18
@fauxpark fauxpark changed the title Add PWM3360 driver Add PMW3360 driver Dec 20, 2020
@stale
Copy link

stale bot commented Feb 3, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Feb 4, 2021
@drashna drashna changed the base branch from master to develop February 17, 2021 12:14
@drashna drashna force-pushed the driver/optical_sensors branch 2 times, most recently from 24c546b to eb279fe Compare February 17, 2021 12:16
@drashna drashna changed the title Add PMW3360 driver Add support for POINTING_DEVICE_DRIVER Feb 17, 2021
fauxpark
fauxpark reviewed Feb 18, 2021
View reviewed changes
drivers/avr/spi_master.h
@@ -39,19 +39,15 @@ typedef int16_t spi_status_t;
#ifdef __cplusplus
extern "C" {
#endif
void spi_init(void);

bool spi_start(pin_t slavePin, bool lsbFirst, uint8_t mode, uint16_t divisor);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

@drashna drashna Feb 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there, just ... formatted, below. yay autoformat

@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:28
@tzarc
Copy link
Member

tzarc commented Feb 27, 2021

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

@tzarc tzarc reopened this Feb 27, 2021
@drashna
Copy link
Member Author

drashna commented May 30, 2021

Depends on #13044

@drashna drashna added the awaiting_pr Relies on another PR to be merged first label May 30, 2021
@drashna drashna closed this Jun 10, 2021
@drashna drashna deleted the driver/optical_sensors branch November 20, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@tzarc tzarc tzarc left review comments

Assignees
No one assigned
Labels
awaiting_pr Relies on another PR to be merged first core documentation in progress keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @fauxpark