Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVR weak bootloader_jump #11418

Merged
merged 1 commit into from
Jan 5, 2021
Merged

AVR weak bootloader_jump #11418

merged 1 commit into from
Jan 5, 2021

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Jan 3, 2021

Description

Allows for a custom implementation of bootloader_jump() for non-standard bootloaders on AVR.

This allows for a cleaner override compared to catching RESET in process_record_* and implementing bootmagic_lite().

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 3, 2021
@tzarc tzarc requested a review from a team January 3, 2021 21:45
@drashna drashna merged commit e7db582 into qmk:develop Jan 5, 2021
@daskygit daskygit deleted the avr_weak_bootloader branch January 5, 2021 08:21
@daskygit daskygit restored the avr_weak_bootloader branch January 6, 2021 14:54
@daskygit daskygit deleted the avr_weak_bootloader branch January 6, 2021 14:55
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@daskygit
Set avr's bootloader_jump function to be weak (qmk#11418)
8de1cc0 
Co-authored-by: Dasky <dasky@nowhere>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daskygit @drashna @tzarc @fauxpark