Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Route around make's unique way of doing things so that we can generate header files reliably.
The tests were broken by #11412, specifically this bit. That was added so that compiling in parallel (EG
make -j 4
) works reliably. However, it turns out that breaksmake test:basic
.This started a long quest to find a way to generate include files while still supporting both tests and parallel make. This process has reminded me, once again, that make is a black box filled with suffering and fondant. That brings us to this monstrosity, something I fear will do great harm to my karmic balance.
This PR creates a new command,
qmk make
, which is designed to sit betweenMakefile
andbuild_keyboard.mk
. It generates include files based on the contents ofinfo.json
and then builds the keyboard/keymap in question.Types of Changes
Checklist