Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on develop #11430

Closed
wants to merge 3 commits into from
Closed

Fix tests on develop #11430

wants to merge 3 commits into from

Conversation

skullydazed
Copy link
Member

Description

Route around make's unique way of doing things so that we can generate header files reliably.

The tests were broken by #11412, specifically this bit. That was added so that compiling in parallel (EG make -j 4) works reliably. However, it turns out that breaks make test:basic.

This started a long quest to find a way to generate include files while still supporting both tests and parallel make. This process has reminded me, once again, that make is a black box filled with suffering and fondant. That brings us to this monstrosity, something I fear will do great harm to my karmic balance.

This PR creates a new command, qmk make, which is designed to sit between Makefile and build_keyboard.mk. It generates include files based on the contents of info.json and then builds the keyboard/keymap in question.

Types of Changes

  • Core
  • Bugfix
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team January 4, 2021 05:49
@github-actions github-actions bot added cli qmk cli command core python labels Jan 4, 2021
@skullydazed
Copy link
Member Author

Thanks to @tzarc's work in #11435 we don't have to unleash this on the world after all.

@skullydazed skullydazed closed this Jan 4, 2021
@skullydazed skullydazed deleted the make_it_workaround branch January 4, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command core python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant