Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport ChibiOS Audio changes from ZSA #11687

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Backport ChibiOS Audio changes from ZSA #11687

merged 1 commit into from
Jan 27, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 25, 2021

Description

Should disable the pins for audio when not in use (playing notes). Added due to issues found with the Planck EZ.

Types of Changes

  • Core
  • Enhancement/optimization

Issues Fixed or Closed by This PR

  • Issues found on planck ez.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from jackhumbert and a team January 25, 2021 05:34
@github-actions github-actions bot added the core label Jan 25, 2021
@tzarc tzarc merged commit bab9849 into qmk:develop Jan 27, 2021
@drashna drashna deleted the fix/audio_chibiOS branch January 30, 2021 16:00
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Backport ChibiOS Audio changes from ZSA (qmk#11687)
cf5c61b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @fauxpark