Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken activation of kinetic mouse mode #11766

Closed
wants to merge 2 commits into from
Closed

fix broken activation of kinetic mouse mode #11766

wants to merge 2 commits into from

Conversation

jceb
Copy link
Contributor

@jceb jceb commented Feb 1, 2021

Description

Fix the activation of the kinetic mouse movement mode.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • no issue filed yet. Defining MK_KINETIC_SPEED according to the documentation didn't work because the if/else define blocks weren't arranged properly.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 1, 2021
drashna
drashna reviewed Feb 5, 2021
View reviewed changes
tmk_core/common/mousekey.c Outdated Show resolved Hide resolved
@jceb jceb closed this Feb 10, 2021
@jceb
Copy link
Contributor Author

jceb commented Feb 10, 2021

closed the PR so that Liyang can integrate it into his PR

liyang added a commit to liyang/qmk_firmware that referenced this pull request Mar 4, 2021
@liyang
quantum/mousekey.{c,h}: untangle #ifndefs with MK_{KIND,TYPE}() m…
a3ee7c7 
…acros

With something `-Wextra` thrown in.

This subsumes @jceb's PR “fix broken activation of kinetic mouse mode” qmk#11766
liyang added a commit to liyang/qmk_firmware that referenced this pull request Mar 4, 2021
@liyang
quantum/mousekey.{c,h}: untangle #ifndefs with MK_{KIND,TYPE}() m…
ea62c80 
…acros

With something `-Wextra` thrown in.

This subsumes @jceb's PR “fix broken activation of kinetic mouse mode” qmk#11766
liyang added a commit to liyang/qmk_firmware that referenced this pull request Mar 4, 2021
@liyang
quantum/mousekey.{c,h}: untangle #ifndefs with MK_{KIND,TYPE}() m…
3b707a6 
…acros

With something `-Wextra` thrown in.

This subsumes @jceb's PR “fix broken activation of kinetic mouse mode” qmk#11766
@liyang liyang mentioned this pull request Mar 4, 2021
Closed
3 tasks
thesecretmaster pushed a commit to thesecretmaster/qmk_firmware that referenced this pull request Nov 30, 2021
@liyang @thesecretmaster
quantum/mousekey.{c,h}: untangle #ifndefs with MK_{KIND,TYPE}() m…
178bbb8 
…acros

With something `-Wextra` thrown in.

This subsumes @jceb's PR “fix broken activation of kinetic mouse mode” qmk#11766
This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jceb @drashna