Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error for tap_code_delay() #11938

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Feb 17, 2021

Description

#11913

On AVR, the parameter to _delay_ms() must be a compile-time constant, so we cannot directly pass in the delay argument here.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 17, 2021 02:53
@tzarc tzarc merged commit be70f46 into qmk:develop Feb 17, 2021
@fauxpark fauxpark deleted the tap-code-delay-fix branch February 17, 2021 06:28
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants