Fix Indicator LED issues with md_rgb_matrix.c

[50an6xy06r6n]

Description

The indicator LED code in md_rgb_matrix.c wasn't built to handle the iterative behavior associated with RGB_MATRIX_LED_PROCESS_LIMIT, causing indicator LED behavior to be buggy (scroll lock broken on Drop CTRL, for example). Modernized the code to use rgb_matrix_indicators_advanced instead.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[zvecr]

As user keymaps would need to be updated, this should really target develop in its current form.

[50an6xy06r6n]

@zvecr why would user keymaps need to be updated?

[50an6xy06r6n]

Changing to target develop, as advised.

[ewersp]

Curious, is the video from this post (eg with the flickering/stuck caps lock key) the buggy behavior you're seeing that this PR now fixes?

If so, that would be great. I shared a video in that Reddit thread with a keymap-level-fix that I was able to make, but would love to replace that with a real fix if possible.

Oh, does this fix apply to CTRL/ALT keyboards using the newer QMK RGB patterns or is this for the older stock RGB code that comes with the Drop keyboards?

[50an6xy06r6n]

@ewersp it might be related, but the issue I was trying to fix was the indicator not following pattern behavior properly. i.e. I had code that inverted the indicator color relative to the underlying pattern, but the inversion was happening multiple times per cycle, since RGB_MATRIX_LED_PROCESS_LIMIT causes the matrix code to operate on smaller blocks. On the CTRL there's 119 LEDs, processed 15 at a time. Scroll lock is in the first block, so it was getting inverted 8 times (i.e. no change), while caps lock is in the 4th block, so it was getting inverted 5 times (thus working as expected). I suppose this might fix flickering, depending on how your inversion code is configured.

This is for a via-enabled keymap I made for the CTRL. Not sure how it would deal with the stock firmware, since I believe that's generated on a legacy branch of QMK

[ewersp]

Ah interesting, I may have noticed the behavior you're describing as well. After a little more digging, I believe the specific issue I was seeing has since been fixed in this PR #10818

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[50an6xy06r6n]

@drashna is there any action needed on my part here?

[drashna]

@zvecr look good?