Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friedrich #12569

Merged
merged 6 commits into from
May 17, 2021
Merged

Friedrich #12569

merged 6 commits into from
May 17, 2021

Conversation

str-dst
Copy link
Contributor

@str-dst str-dst commented Apr 13, 2021

Description

Added the Friedrich50 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 13, 2021
@str-dst str-dst mentioned this pull request Apr 13, 2021
Merged
6 tasks
drashna
drashna approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@drashna drashna requested a review from a team April 20, 2021 20:02
fauxpark
fauxpark approved these changes Apr 21, 2021
View reviewed changes
keyboards/friedrich/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@str-dst @fauxpark
Update keyboards/friedrich/keymaps/via/rules.mk
f77c1ee 
Co-authored-by: Ryan <fauxpark@gmail.com>
@str-dst @noroadsleft
change USB name casing
17d31ad 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit f7c6d68 into qmk:master May 17, 2021
@noroadsleft
Copy link
Member

Thanks!

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@str-dst @HokieGeek
[Keyboard] Friedrich (qmk#12569)
6e46704 
* added Friedrich

* Update readme.md

* Update readme.md

* Update keyboards/friedrich/keymaps/via/rules.mk

* change USB name casing
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@str-dst @nhongooi
[Keyboard] Friedrich (qmk#12569)
8adbcbe 
* added Friedrich

* Update readme.md

* Update readme.md

* Update keyboards/friedrich/keymaps/via/rules.mk

* change USB name casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@str-dst @noroadsleft @drashna @fauxpark