Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Yasui keyboard #12726

Merged
merged 9 commits into from
May 17, 2021
Merged

Added Yasui keyboard #12726

merged 9 commits into from
May 17, 2021

Conversation

rainkeebs
Copy link
Contributor

Added Yasui keyboard from rainkeebs

Description

Added Yasui keyboard support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 28, 2021
@rainkeebs rainkeebs mentioned this pull request Apr 28, 2021
Merged
6 tasks
ridingqwerty
ridingqwerty requested changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change all instances of KEYMAP to LAYOUT

@rainkeebs rainkeebs requested a review from ridingqwerty April 29, 2021 03:58
rainkeebs
rainkeebs commented Apr 29, 2021
View reviewed changes
Copy link
Contributor Author

@rainkeebs rainkeebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rainkeebs rainkeebs requested a review from ridingqwerty May 17, 2021 22:24
@ridingqwerty
Copy link
Contributor

Thanks!

@ridingqwerty ridingqwerty merged commit 22e9a0b into qmk:master May 17, 2021
TLBarber pushed a commit to TLBarber/qmk_firmware that referenced this pull request May 18, 2021
@rainkeebs @TLBarber
Added Yasui keyboard (qmk#12726)
13e577f 
* initial

* fix

* Update config.h

* Update config.h

* Update rules.mk

* Delete info.json

* fuix

* PR work

* replace keymap with layout

Co-authored-by: rainsff <44819800+rainsff@users.noreply.github.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@rainkeebs @HokieGeek
Added Yasui keyboard (qmk#12726)
c3a20d4 
* initial

* fix

* Update config.h

* Update config.h

* Update rules.mk

* Delete info.json

* fuix

* PR work

* replace keymap with layout

Co-authored-by: rainsff <44819800+rainsff@users.noreply.github.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@rainkeebs @nhongooi
Added Yasui keyboard (qmk#12726)
35307e4 
* initial

* fix

* Update config.h

* Update config.h

* Update rules.mk

* Delete info.json

* fuix

* PR work

* replace keymap with layout

Co-authored-by: rainsff <44819800+rainsff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@ridingqwerty ridingqwerty Awaiting requested review from ridingqwerty

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rainkeebs @ridingqwerty @drashna