Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment parsing #12750

Merged
merged 5 commits into from
May 3, 2021
Merged

Fix comment parsing #12750

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f13b3d
Require a space after single line comment start
skullydazed Apr 30, 2021
2082aa7
fix boards broken by the last commit
skullydazed Apr 30, 2021
bec0716
Update lib/python/qmk/c_parse.py
skullydazed May 1, 2021
1f665f2
Revert "fix boards broken by the last commit"
skullydazed May 1, 2021
f1510dd
fix monstargear/xo87/rgb
skullydazed May 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keyboards/labyrinth75/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
//#define BACKLIGHT_LEVELS 3
//#define BACKLIGHT_BREATHING

#define RGB_DI_PIN B0 //D5 could also be the other pin maybe
#define RGB_DI_PIN B0 // D5 could also be the other pin maybe
//#ifdef RGB_DI_PIN
#define RGBLED_NUM 6
//# define RGBLIGHT_HUE_STEP 8
Expand Down
4 changes: 2 additions & 2 deletions keyboards/leafcutterlabs/bigknob/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define ENCODER_RESOLUTION 4 //default/suggested

/* ws2812 RGB LED */
#define RGB_DI_PIN C7 //D3 - underglow C7 - backlight
#define RGB_DI_PIN C7 // D3 - underglow C7 - backlight
#define RGBLIGHT_ANIMATIONS
#define RGBLED_NUM 5 // Number of LEDs
#define RGBLED_NUM 5 // Number of LEDs
2 changes: 1 addition & 1 deletion keyboards/monstargear/xo87/rgb/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#define MATRIX_COLS 16

#define BACKLIGHT_PIN F5
#define MATRIX_ROW_PINS { E6,E7, E3, B0, B1 ,A2}//
#define MATRIX_ROW_PINS { E6,E7, E3, B0, B1 ,A2}
#define MATRIX_COL_PINS { C5,C3,C1,E1,D6,D2,B7,B3,F6,F7,F3,A5,A1,E2,C7,A6 }
#define UNUSED_PINS
#define DIODE_DIRECTION ROW2COL
Expand Down
2 changes: 1 addition & 1 deletion keyboards/sam/sg81m/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

#define DIODE_DIRECTION COL2ROW

#define RGB_DI_PIN E6 //reserved pin for potential underglow rgb
#define RGB_DI_PIN E6 // reserved pin for potential underglow rgb
#ifdef RGB_DI_PIN
#define RGBLED_NUM 10
#define RGBLIGHT_HUE_STEP 8
Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/c_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from qmk.comment_remover import comment_remover

default_key_entry = {'x': -1, 'y': 0, 'w': 1}
single_comment_regex = re.compile(r' */[/*].*$')
single_comment_regex = re.compile(r' */[/*] .*$')
skullydazed marked this conversation as resolved.
Show resolved Hide resolved
multi_comment_regex = re.compile(r'/\*(.|\n)*?\*/', re.MULTILINE)


Expand Down