Add via support for the Leopold FC980C #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
penmoid
changed the title
drashna
requested changes
May 13, 2021
drashna
approved these changes
May 13, 2021
|
@drashna Does this require further review before it can be merged? |
|
Yeah. Generally, we want two reviews before merging. Mostly, to make sure that no one set of eyes has missed anything. It still happens, but two sets makes it much less likely. |
fauxpark
requested changes
May 27, 2021
fauxpark
requested changes
May 28, 2021
|
@fauxpark Are there any remaining changes that need to be made in this PR? |
fauxpark
approved these changes
Jun 9, 2021
|
Thanks! |
6 tasks
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds Via support to the FC980C. The board's config.h file was updated to match the manufacturer and model naming convention from the FC660C, which already has Via support. A Via keymap was added, and due to EEPROM size constraints the configuration has been limited to 3 dynamic layers.
Types of Changes
Issues Fixed or Closed by This PR
Checklist