Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter filelist for CI #12903

Closed
wants to merge 1 commit into from
Closed

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented May 14, 2021

Description

The format workflow has limited scope, but will happily run on anything if even one of the touched files are from its scope.
This PR filters down the file list that is passed to qmk cformat to the paths that are actually in scope.

Test case:
#12597 fails because keyboard files are "incorrectly" formatted.
Erovia#1 fails because a core file is incorrectly formatted.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the CI label May 14, 2021
@Erovia Erovia requested a review from a team May 14, 2021 19:13
@Erovia Erovia changed the title Filter filelist Filter filelist for CI May 14, 2021
@Erovia Erovia closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant