[Keyboard] Added bradpad support #12912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
6 tasks
drashna
requested changes
May 15, 2021
|
@drashna do you have any idea why it keeps trying to pull in whatever's going on with chibiOS and how to avoid it? I haven't touched the submodules at all but it keeps sneaking into my commits. Last time I fixed it by just creating a new branch, but this seems like it just wants to keep creeping back. |
|
For reference how I resolved the chibiOS stuff is as follows:
I might make a pr for a change to the .gitmodules the future to set the chibios as "ignore=dirty" because I know that I'm not the only one who has had to deal with that weirdness. |
fauxpark
requested changes
May 16, 2021
Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
approved these changes
May 16, 2021
fauxpark
approved these changes
May 16, 2021
|
Thanks! |
|
Thanks for the review guys! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com>
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the bradpad an upcoming stocked macropad
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Extra Info:
see: #12907 for commit history, chose to rebranch and compress because of some submodule weirdness.