Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update encoder logic #13109

Closed
wants to merge 14 commits into from
Closed

Update encoder logic #13109

wants to merge 14 commits into from

Conversation

RinoSolutions
Copy link

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • [ x] Enhancement/optimization
  • Keyboard (addition or update)
  • [x ] Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 4, 2021
@stale
Copy link

stale bot commented Jul 22, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

drashna
drashna requested changes Jul 23, 2021
View reviewed changes
keyboards/monarch/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/monarch/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/monarch/keymaps/iso/keymap.c Outdated Show resolved Hide resolved
keyboards/monarch/keymaps/iso/keymap.c Outdated Show resolved Hide resolved
@stale stale bot removed the awaiting changes label Jul 23, 2021
@drashna drashna requested a review from a team July 23, 2021 02:02
RinoSolutions and others added 3 commits August 17, 2021 20:30
@RinoSolutions @drashna
Update keyboards/monarch/keymaps/default/keymap.c
d6eca14 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@RinoSolutions @drashna
Update keyboards/monarch/keymaps/default/keymap.c
c45473e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@RinoSolutions @drashna
Update keyboards/monarch/keymaps/iso/keymap.c
ff34d4f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
RinoSolutions
RinoSolutions commented Aug 18, 2021
View reviewed changes
Copy link
Author

@RinoSolutions RinoSolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not moved the logic from the iso/keymap.c file because I'm not totally sure where to put it exactly.

drashna
drashna requested changes Sep 11, 2021
View reviewed changes
keyboards/monarch/keymaps/via/keymap.c Outdated Show resolved Hide resolved
RinoSolutions and others added 2 commits September 24, 2021 14:51
@RinoSolutions @drashna
Update keyboards/monarch/keymaps/iso/keymap.c
75b9ad8 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@RinoSolutions @drashna
Update keyboards/monarch/keymaps/via/keymap.c
a113acc 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@RinoSolutions
Copy link
Author

I accepted the requested change .

drashna
drashna reviewed Sep 24, 2021
View reviewed changes
keyboards/monarch/keymaps/default/keymap.c
uint16_t keycode = get_event_keycode(pressed, false);
if (keycode > 0) {
uint16_t held_keycode_timer = timer_read();
register_code16(keycode);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will miss most keycodes that aren't basic keycodes.

A better option is to use action_exec to trigger the matrix locations, rather than this.

You can see an example of what I mean in keyboards/work_louder/encoder_actions.c

@stale
Copy link

stale bot commented Nov 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale
Copy link

stale bot commented Jan 9, 2022

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

Assignees
No one assigned
Labels
awaiting changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RinoSolutions @drashna