Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data buffer overrun and OLED corruption bug in oled_write_raw when cursor not at origin (0, 0) #13204

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Jun 13, 2021

Description

See #13203 for details on the bug itself. For simplicity, I updated oled_write_raw to follow the (non-buggy) pattern that oled_write_raw_P already uses for reads (incrementing the data pointer rather than indexing into it using array syntax).

Verified this fixes the display corruption bug for OLED on ARM. See before (with corruption) and after (without corruption) this fix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 13, 2021
@drashna drashna requested a review from a team June 14, 2021 01:00
@drashna drashna added the bug label Jun 14, 2021
@drashna drashna merged commit 83ee795 into qmk:master Jun 16, 2021
@bcat bcat deleted the oled_write_raw branch June 16, 2021 14:24
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] oled_write_raw overruns data buffer, corrupts display when cursor not at origin (0, 0)
3 participants