Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRC for AVR and enable again. #13253

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Fix CRC for AVR and enable again. #13253

merged 2 commits into from
Jun 26, 2021

Conversation

daskygit
Copy link
Member

I don't really understand the implications of QUANTUM_LIB_SRC vs SRC.

I noticed removing the weak attribute on crc_init() threw up a undefined error in keyboard.c, so assumed it wasn't getting included correctly.

I've flashed this on a spare promicro and it seems to work correctly with the crkbd and kyria default keymaps. Might be good for someone else to confirm.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 20, 2021
@drashna drashna requested a review from a team June 26, 2021 05:23
@drashna
Copy link
Member

drashna commented Jun 26, 2021

I don't really understand the implications of QUANTUM_LIB_SRC vs SRC.

QUANTUM_LIB_SRC is added separately, and later in the compilation process, doesn't get optimization applied to it, and can be compiled out completely, if not needed. IIRC.

Usually, it's best to use SRC, unless there are timing issues or weird behavior, especially with LTO enabled.

@drashna drashna merged commit cd30861 into qmk:develop Jun 26, 2021
@daskygit daskygit deleted the crc-fix branch July 21, 2021 16:50
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants