Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Serratus PCB #13281

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Add Serratus PCB #13281

merged 7 commits into from
Jul 14, 2021

Conversation

mechlovin
Copy link
Contributor

Description

Add Serratus TKL PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 21, 2021
drashna
drashna requested changes Jun 21, 2021
View reviewed changes
@mechlovin
Copy link
Contributor Author

Thank you. I have tested polling rate on my board and forgot to delete them.

@mechlovin mechlovin requested a review from fauxpark July 2, 2021 03:36
@mechlovin
Copy link
Contributor Author

Hi. @fauxpark.
Anything else I can do?

fauxpark
fauxpark requested changes Jul 14, 2021
View reviewed changes
@mechlovin @fauxpark
Update keyboards/mechlovin/serratus/readme.md
795b779 
Co-authored-by: Ryan <fauxpark@gmail.com>
@mechlovin
Copy link
Contributor Author

Thank you.

@drashna
Copy link
Member

drashna commented Jul 14, 2021

Thanks!

@drashna drashna merged commit 18c6e1d into qmk:master Jul 14, 2021
@mechlovin mechlovin mentioned this pull request Jul 21, 2021
Merged
6 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@mechlovin @fauxpark @nhongooi
[Keyboard] Add Serratus PCB (qmk#13281)
cedd96d 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mechlovin @drashna @fauxpark