Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linker error when rgblight and RGB Matrix are both enabled #13304

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

fauxpark
Copy link
Member

Description

 | 
 | /usr/local/opt/avr-binutils/bin/avr-ld: .build/obj_planck_light_drashna/color.o (symbol from plugin): in function `hsv_to_rgb_impl':
 | (.text+0x0): multiple definition of `hsv_to_rgb_impl'; .build/obj_planck_light_drashna/quantum/color.o (symbol from plugin):(.text+0x0): first defined here
 | /usr/local/opt/avr-binutils/bin/avr-ld: .build/obj_planck_light_drashna/color.o (symbol from plugin): in function `hsv_to_rgb_impl':
 | (.text+0x0): multiple definition of `hsv_to_rgb'; .build/obj_planck_light_drashna/quantum/color.o (symbol from plugin):(.text+0x0): first defined here
 | /usr/local/opt/avr-binutils/bin/avr-ld: .build/obj_planck_light_drashna/color.o (symbol from plugin): in function `hsv_to_rgb_impl':
 | (.text+0x0): multiple definition of `hsv_to_rgb_nocie'; .build/obj_planck_light_drashna/quantum/color.o (symbol from plugin):(.text+0x0): first defined here
 | collect2: error: ld returned 1 exit status

Presumably caused by the creation of two object files from color.c in different build directories.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 23, 2021 00:47
@drashna drashna requested a review from a team June 23, 2021 00:48
@fauxpark fauxpark merged commit 4319aca into qmk:develop Jun 23, 2021
@fauxpark fauxpark deleted the rgb-fix branch June 23, 2021 00:53
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants