Userspace: muppetjones (#1) #13461

muppetjones · 2021-07-06T03:50:52Z

Description

This PR adds:

My userspace
Planck keymap
Lily58 keymap
Kyria keymap

My userspace and keymaps incorporate code from the following users:

@splitkb (optimizations)
@drashna (wrapper.h pattern)
@andrewjrae (casemodes)
@j-inc (bongo cat)

I've added the following features in my userspace and keymaps. As I clean up and optimize these features, I'll add them into the main code base.

Etch-a-Mouse: Encoder-based pointing device movement with acceleration.
Dynamic, Layer-based RGB: RGB underglow that changes with your layers and respects your current RGB settings. (Need to move this from my kyria into my userspace).

This PR only includes one change outside of my user-specific code: Updates to keyboards/lily58/lib/layer_state_reader.c. The default Lily58 keymap did not compile without these updates.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Add and update lily58 to work with userspace Add and update kyria keymap to work with userspace Add and update planck keymap with userspace Add etchamouse code and docs to userpace Add userspace Update mouse encoder for smoother movement. Encoder + mouse Added casemodes by andrewjrae

keyboards/lily58/lib/layer_state_reader.c

users/muppetjones/rules.mk

keyboards/kyria/keymaps/muppetjones/rules.mk

keyboards/lily58/keymaps/muppetjones/features/bongo_cat.c

keyboards/lily58/keymaps/muppetjones/keymap.c

keyboards/lily58/keymaps/muppetjones/rules.mk

keyboards/lily58/keymaps/muppetjones/config.h

users/muppetjones/config.h

users/muppetjones/features/etchamouse.h

muppetjones · 2021-07-07T14:24:55Z

keyboards/lily58/lib/layer_state_reader.c


-  return layer_state_str;
+    return layer_state_str;


Whitespace changes due to clang-format.
Rolled back the layer definitions, but kept "duo".

If anything, this should be copied to your keymap, rather than altered.

Also, snprintf should be avoid whenever possible, as it adds ~1.5k to the compiled size, even with LTO enabled.

Restored the original.

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com>

muppetjones · 2021-07-07T14:28:37Z

@drashna @zvecr Made suggested changes. Thanks for the review!

keyboards/lily58/keymaps/muppetjones/config.h

keyboards/lily58/keymaps/muppetjones/features/bongo_cat.c

Updated parameters for etchamouse for smoother mouse movement. Updated lily keymap and userspace to actually work together.

muppetjones · 2021-07-11T16:16:51Z

@drashna Thank you for the second review. All of the comments have been addressed.

I updated and changed some things while trying to debug a ghosting problem. I saw the behaviour on my kyria initially, but also when I flashed my lily with the original updates I posted here. The keys ghosting were different on the lily; however, it was still multiple keys at once. The issue seems to be in QMK or chibios as the WPM display was always high -- hanging around 128-255. More likely, there was a change in either that isn't compatible with the WPM interface that the included bongo cat code is using.

I was originally using 0.11.* with no issue, but I had pulled in the latest master (0.13.*) to get my fork up to speed. Rolling back the QMK version and the chibios version to the most recent 0.11 fixed both the ghosting and the WPM.

All of my changes actually line up with the second round of requested changes. I haven't retested on 0.13 yet. I'm going to get my testing and dev setup a little more stable and see if I can't track down the source of the above issue. If I find anything, I'll open a new PR.

drashna · 2021-07-11T16:32:06Z

Yeah, there is an issue with the WPM code right now. IIRC, there is a proposed fix for that.

Also, develop seems to handle the split code better.

Co-authored-by: Drashna Jaelre <drashna@live.com>

keyboards/lily58/keymaps/muppetjones/keymap.c

keyboards/planck/keymaps/muppetjones/config.h

keyboards/lily58/keymaps/muppetjones/rules.mk

keyboards/planck/keymaps/muppetjones/keymap.c

muppetjones · 2021-07-17T20:03:50Z

Not going to lie, I'm not a fan of requested changes that have zero effect on the code base (and one that actually affects compile negatively). All but one (the colors in the planck) are sections from the default keymap for that board that I had left for one reason or another. Had these been changes submitted that hit the actual codebase, I certainly would have cleaned those up beforehand, and could understand the requested changes if I had missed them.

I'm all for constructive criticism, but removing inconsequential comments and "requiring changes"...it just slows down and frustrates the review process. I've been on the reviewer side in that situation several times. A word of advice: Just "comment" instead of "request changes". If it really is critical to have the extra comments removed, please say so.

fauxpark · 2021-07-17T20:12:26Z

@muppetjones it's preferable to get things like this done before the PR is merged and is potentially copy-pasted into other users' code, bloating the repo. It's then harder for us to clean it up afterwards, because we generally require signoff from the affected users (or at least provide a heads up) when modifying their code.

muppetjones · 2021-07-23T13:30:08Z

@fauxpark That's good reasoning. I appreciate the response. I'll clean it up, and I'll see about another PR to clean up the defaults that I copied from.

…rmware into userspace-muppetjones

muppetjones · 2021-07-31T17:35:41Z

@fauxpark @zvecr I've made the requested changes -- thanks for the patience and the feedback.

muppetjones · 2021-08-15T20:24:57Z

Bump for re-review when you get a chance. Thanks!
@fauxpark @zvecr

keyboards/lily58/keymaps/muppetjones/README.md

keyboards/lily58/keymaps/muppetjones/keymap.c

drashna · 2022-03-23T05:35:51Z

keyboards/planck/keymaps/muppetjones/keymap.c

+    return true;
+}
+
+void dip_switch_update_user(uint8_t index, bool active) {


Suggested change

void dip_switch_update_user(uint8_t index, bool active) {

bool dip_switch_update_user(uint8_t index, bool active) {

Still needs to be addressed

drashna · 2022-03-23T05:36:17Z

keyboards/planck/keymaps/muppetjones/keymap.c

+                muse_mode = false;
+            }
+    }
+}


Suggested change

}

return true;

}

users/muppetjones/README.md

users/muppetjones/config.h

keyboards/lily58/keymaps/muppetjones/README.md

Co-authored-by: Drashna Jaelre <drashna@live.com>

…rmware into userspace-muppetjones

keyboards/lily58/keymaps/muppetjones/config.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

muppetjones · 2022-04-05T04:05:37Z

@drashna g2g

stale · 2022-06-12T14:55:09Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2022-07-29T02:17:11Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboard-magpie · 2022-08-03T17:22:49Z

mis-requested review sorry drashna!

muppetjones · 2022-08-03T17:24:11Z

Thanks!!

* Userspace: muppetjones (#1) Add and update lily58 to work with userspace Add and update kyria keymap to work with userspace Add and update planck keymap with userspace Add etchamouse code and docs to userpace Add userspace Update mouse encoder for smoother movement. Encoder + mouse Added casemodes by andrewjrae * Rollback lily58 state reader and add missing GPL * Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> * fix lily58 keymap * Updates to user and lily for muppetjones. Updated parameters for etchamouse for smoother mouse movement. Updated lily keymap and userspace to actually work together. * Update keyboards/lily58/keymaps/muppetjones/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> * Updated keymaps and userspace * Little more cleanup. * Update keyboards/lily58/keymaps/muppetjones/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Rollback accidental libchibios update * Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com> * Update kyria keymap * Move kyria keymap to splitkb/kyria * Update planck keymap * Remove all changes to keyboards/lily58/lib/layer_state_reader.c * Update lily58 keymap * Recommended change * Update keymap readme * Update kyria keymap and userspace * Apply suggestions from code review Co-authored-by: Drashna Jaelre <drashna@live.com> * Renamed users/muppetjones/README.md to lc * Update keyboards/lily58/keymaps/muppetjones/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>

github-actions bot added keyboard keymap labels Jul 6, 2021

zvecr requested changes Jul 6, 2021

View reviewed changes

keyboards/lily58/lib/layer_state_reader.c Outdated Show resolved Hide resolved

users/muppetjones/rules.mk Outdated Show resolved Hide resolved

zvecr requested a review from a team July 6, 2021 17:11

drashna reviewed Jul 6, 2021

View reviewed changes

keyboards/kyria/keymaps/muppetjones/rules.mk Outdated Show resolved Hide resolved

drashna requested changes Jul 6, 2021

View reviewed changes

Rollback lily58 state reader and add missing GPL

1f726c9

muppetjones commented Jul 7, 2021

View reviewed changes

Apply suggestions from code review

f5138d8

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com>

fix lily58 keymap

74534b5

drashna reviewed Jul 11, 2021

View reviewed changes

keyboards/lily58/keymaps/muppetjones/config.h Outdated Show resolved Hide resolved

drashna requested changes Jul 11, 2021

View reviewed changes

keyboards/lily58/keymaps/muppetjones/features/bongo_cat.c Outdated Show resolved Hide resolved

keyboards/lily58/keymaps/muppetjones/features/bongo_cat.c Outdated Show resolved Hide resolved

keyboards/lily58/keymaps/muppetjones/features/bongo_cat.c Outdated Show resolved Hide resolved

Updates to user and lily for muppetjones.

7f87420

Updated parameters for etchamouse for smoother mouse movement. Updated lily keymap and userspace to actually work together.

drashna approved these changes Jul 11, 2021

View reviewed changes

drashna requested a review from a team July 11, 2021 16:01

Update keyboards/lily58/keymaps/muppetjones/config.h

ae8d7f1

Co-authored-by: Drashna Jaelre <drashna@live.com>

fauxpark requested changes Jul 11, 2021

View reviewed changes

muppetjones added 2 commits July 31, 2021 12:25

Updated keymaps and userspace

7d26091

Merge branch 'userspace-muppetjones' of github.com:muppetjones/qmk_fi…

59da7b2

…rmware into userspace-muppetjones

github-actions bot added the dependencies label Jul 31, 2021

Little more cleanup.

f126e1e

muppetjones requested a review from drashna March 20, 2022 17:37

drashna requested changes Mar 23, 2022

View reviewed changes

muppetjones commented Mar 24, 2022

View reviewed changes

keyboards/lily58/keymaps/muppetjones/README.md Outdated Show resolved Hide resolved

muppetjones and others added 3 commits March 24, 2022 09:19

Apply suggestions from code review

229c255

Co-authored-by: Drashna Jaelre <drashna@live.com>

Renamed users/muppetjones/README.md to lc

0c5e1e6

Merge branch 'userspace-muppetjones' of github.com:muppetjones/qmk_fi…

753681e

…rmware into userspace-muppetjones

drashna requested changes Mar 26, 2022

View reviewed changes

keyboards/lily58/keymaps/muppetjones/config.h Outdated Show resolved Hide resolved

Update keyboards/lily58/keymaps/muppetjones/config.h

7573994

Co-authored-by: Drashna Jaelre <drashna@live.com>

muppetjones requested a review from drashna April 5, 2022 04:05

drashna approved these changes Apr 13, 2022

View reviewed changes

drashna requested review from a team and drashna April 13, 2022 05:11

stale bot added the awaiting changes label Jun 12, 2022

drashna approved these changes Jun 13, 2022

View reviewed changes

stale bot removed the awaiting changes label Jun 13, 2022

drashna requested a review from a team June 13, 2022 06:11

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 29, 2022

drashna approved these changes Jul 30, 2022

View reviewed changes

drashna removed the stale Issues or pull requests that have become inactive without resolution. label Jul 30, 2022

keyboard-magpie approved these changes Aug 3, 2022

View reviewed changes

keyboard-magpie requested a review from drashna August 3, 2022 17:22

keyboard-magpie merged commit df8a538 into qmk:master Aug 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Userspace: muppetjones (#1) #13461

Userspace: muppetjones (#1) #13461

muppetjones commented Jul 6, 2021

muppetjones Jul 7, 2021 •

edited

Loading

drashna Nov 28, 2021

muppetjones Mar 22, 2022

muppetjones commented Jul 7, 2021

muppetjones commented Jul 11, 2021 •

edited

Loading

drashna commented Jul 11, 2021

muppetjones commented Jul 17, 2021

fauxpark commented Jul 17, 2021

muppetjones commented Jul 23, 2021

muppetjones commented Jul 31, 2021

muppetjones commented Aug 15, 2021

drashna Mar 23, 2022

drashna Apr 13, 2022

drashna Mar 23, 2022

muppetjones commented Apr 5, 2022

stale bot commented Jun 12, 2022

github-actions bot commented Jul 29, 2022

keyboard-magpie commented Aug 3, 2022

muppetjones commented Aug 3, 2022

	void dip_switch_update_user(uint8_t index, bool active) {
	bool dip_switch_update_user(uint8_t index, bool active) {

Userspace: muppetjones (#1) #13461

Userspace: muppetjones (#1) #13461

Conversation

muppetjones commented Jul 6, 2021

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

muppetjones Jul 7, 2021 • edited Loading

Choose a reason for hiding this comment

drashna Nov 28, 2021

Choose a reason for hiding this comment

muppetjones Mar 22, 2022

Choose a reason for hiding this comment

muppetjones commented Jul 7, 2021

muppetjones commented Jul 11, 2021 • edited Loading

drashna commented Jul 11, 2021

muppetjones commented Jul 17, 2021

fauxpark commented Jul 17, 2021

muppetjones commented Jul 23, 2021

muppetjones commented Jul 31, 2021

muppetjones commented Aug 15, 2021

drashna Mar 23, 2022

Choose a reason for hiding this comment

drashna Apr 13, 2022

Choose a reason for hiding this comment

drashna Mar 23, 2022

Choose a reason for hiding this comment

muppetjones commented Apr 5, 2022

stale bot commented Jun 12, 2022

github-actions bot commented Jul 29, 2022

keyboard-magpie commented Aug 3, 2022

muppetjones commented Aug 3, 2022

muppetjones Jul 7, 2021 •

edited

Loading

muppetjones commented Jul 11, 2021 •

edited

Loading