Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4pplet AEKISO60 keymap/macro touch-up #13528

Merged
merged 1 commit into from
Jul 13, 2021
Merged

4pplet AEKISO60 keymap/macro touch-up #13528

merged 1 commit into from
Jul 13, 2021

Conversation

noroadsleft
Copy link
Member

Description

Moves the ISO Enter keycode to the home row for more consistency with the rest of QMK. Also grid-aligns the keycodes and adds a block comment for the layout macro.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
keymap/macro touch-up
a2b6054 
Moves the ISO Enter keycode to the home row for more consistency with the rest of QMK. Also grid-aligns the keycodes and adds a block comment for the layout macro.
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 12, 2021
@noroadsleft noroadsleft requested a review from a team July 12, 2021 17:44
@noroadsleft
Copy link
Member Author

Forgot to tag @4pplet (keyboard maintainer).

@noroadsleft noroadsleft merged commit a3d6046 into qmk:master Jul 13, 2021
@noroadsleft noroadsleft deleted the cf/aekiso60 branch July 13, 2021 21:04
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@noroadsleft @nhongooi
4pplet AEKISO60 keymap/macro touch-up (qmk#13528)
d6b44ae 
Moves the ISO Enter keycode to the home row for more consistency with the rest of QMK. Also grid-aligns the keycodes and adds a block comment for the layout macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark