Skip to content

[Keyboard] New Keyboard - OBE #13545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jul 22, 2021
Merged

[Keyboard] New Keyboard - OBE #13545

merged 42 commits into from
Jul 22, 2021

Conversation

kylemccreery
Copy link
Contributor

Description

Initial PR for adding the OrangeBoyErgo (OBE) keyboard kit by MechWild. This is the default and VIA keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

kylemccreery and others added 29 commits January 11, 2021 16:20
@kylemccreery
Initial commit of base IBKH firmware.
db068ee
@kylemccreery
Rebuilt firmware from scratch to avoid compilation errors from copyin…
05621e0 
…g old split source code. running into an issue now with col1 and row1 both not responding.
@kylemccreery
Merge branch 'ilex' of https://github.com/kylemccreery/qmk_firmware i…
dac6f3c 
…nto ilex
@kylemccreery
ilex added, removed other test builds
7ecfc60
@kylemccreery
Initial commit
ff7d6fa
@kylemccreery
Finished working default firmware. Still needs updated readme aadme a…
7e5e878 
…nd info.json
@kylemccreery
Added OLED functionality, updated logo font file, added VIA and VIAL …
aed955b 
…support, removed IBKH from this branch.
@kylemccreery
Merge branch 'master' of github.com:qmk/qmk_firmware into murphpad
f0eff66
@kylemccreery
Reverting changes related to Ilex development that got merged into th…
c66707b 
…e master.
@kylemccreery
updated in prep of PR
374a741
@kylemccreery
Cleaned up MurphPad files for PR.
296cae1
@kylemccreery
Removed VIAL keymap for ease of PR approval.
d9226ef
@kylemccreery @fauxpark
Apply suggestions from code review
d8c4e45 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kylemccreery
go away chibios
51b7b1a
@kylemccreery
Merge branch 'murphpad' of https://github.com/kylemccreery/qmk_firmware…
9ea65dd 
… into murphpad
@kylemccreery
Initial obe firmware build prelim work
22bf67f
@kylemccreery
Working prototype. needs to be cleaned.
dacbc23
@kylemccreery
Merge branch 'master' of github.com:qmk/qmk_firmware into obe
eaf207b
@kylemccreery
Cleaning up from initial push
0775d75
@kylemccreery
Added support for both black pill variants. Added VIA map to get read…
187f13c 
…y for eeprom addition for next version. Cleaned up files in general.
@kylemccreery
Merge branch 'master' of https://github.com/qmk/qmk_firmware into obe
7dc3414
@kylemccreery
Merge branch 'master' of github.com:qmk/qmk_firmware into obe
8a617e6
@kylemccreery
Updating keymap
3a4d40e
@kylemccreery
Merge branch 'obe' of github.com:kylemccreery/qmk_firmware into obe
6e5ca1a
@kylemccreery
Trying to figure out eeprom
fc72433
@kylemccreery
Resolved problems with first prototype, added support for i2c eeprom,…
c866291 
… reassigned pins from boot1 and i2c1
@kylemccreery
Merge branch 'master' of github.com:qmk/qmk_firmware into obe
7a83753
@kylemccreery
Updated info files in preparation for PR and cleaned everything up.
e4fbb9c
@kylemccreery
Unchanging the murphpad file I was toying with.
590744d
@kylemccreery kylemccreery requested a review from drashna July 20, 2021 02:15
@kylemccreery
Copy link
Contributor Author

@drashna retagging for rereview was a mistake. I was just gonna comment asking if you need to rerequest qmk reviewers. My bad.

@drashna drashna requested a review from a team July 20, 2021 03:35
@drashna
Copy link
Member

drashna commented Jul 20, 2021

No worries

fauxpark
fauxpark requested changes Jul 20, 2021
View reviewed changes
@drashna drashna requested a review from a team July 20, 2021 05:06
@kylemccreery
Copy link
Contributor Author

@fauxpark I added the BOOTLOADER section to the rules.mk files while removing the STM32_BOOTLOADER_ADDRESS per your comment on #12956

Please advise if that was not correct. It seems a lot like I started writing this firmware directly before a lot of stm32 changes came into play so I was immediately outdated on stuff before submitting for PR

fauxpark
fauxpark requested changes Jul 21, 2021
View reviewed changes
@fauxpark
Copy link
Member

@kylemccreery good catch, I completely forgot about that.

kylemccreery and others added 2 commits July 20, 2021 22:55
@kylemccreery @fauxpark
Update keyboards/mechwild/obe/f401/rules.mk
0bfc64a 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kylemccreery @fauxpark
Update keyboards/mechwild/obe/f411/rules.mk
5e9d748 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kylemccreery
Copy link
Contributor Author

@kylemccreery good catch, I completely forgot about that.

I only knew because I had to look up why you suggested the removal in the first place haha. I am glad a lot of the stm32 stuff is advancing so much recently.

fauxpark
fauxpark approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is complaining about missing readmes, but there is one at the top level so it's OK.

@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit 5766b9b into qmk:master Jul 22, 2021
@kylemccreery kylemccreery mentioned this pull request Jul 23, 2021
Merged
6 tasks
@kylemccreery kylemccreery deleted the obe branch September 9, 2021 03:17
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@kylemccreery @fauxpark
@drashna @nhongooi
[Keyboard] New Keyboard - OBE (qmk#13545)
92012b1 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylemccreery @drashna @fauxpark