Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary rgblight.h include. #13555

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Jul 15, 2021

Description

remove #include "rgblight.h" when defined(RGB_MATRIX_ENABLE) from quantum.h

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 15, 2021
@mtei mtei closed this Jul 15, 2021
@mtei mtei reopened this Jul 16, 2021
@mtei mtei marked this pull request as ready for review July 16, 2021 02:08
@mtei mtei requested a review from a team July 16, 2021 02:09
@drashna drashna requested review from fauxpark and a team July 16, 2021 02:25
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be removed from the RGB Matrix VPATH in common_features.mk

@mtei
Copy link
Contributor Author

mtei commented Jul 16, 2021

Should also be removed from the RGB Matrix VPATH in common_features.mk

% grep rgblight_list quantum/rgb_matrix*.[ch]
quantum/rgb_matrix.h:#include "rgblight_list.h"

@fauxpark
Copy link
Member

#13371

@mtei
Copy link
Contributor Author

mtei commented Jul 16, 2021

This PR target is 'master'. Like #13509

@fauxpark
Copy link
Member

Ah right. So my PR can be reverted once this is merged.

@mtei mtei merged commit 5fda0e2 into qmk:master Jul 16, 2021
@LechuckThePirate
Copy link

LechuckThePirate commented Jul 16, 2021

I lost my rgb when I applied this tag. Should I make any modifications to my keymap?? I'm using RGBLIGHTS not RGB MATRIX

RGBLIGHT_ENABLE     = yes # Enable RGB Lights
VIA_ENABLE          = no # Enable VIA, if you're not gonna use it, set to 'no'
OLED_DRIVER_ENABLE  = yes # Enable OLED screens
LTO_ENABLE          = yes # Makes the firmware smaller, takes more time to compile
EXTRAKEY_ENABLE     = yes # Enables System and Media control keys
SPLIT_KEYBOARD 		= yes # You have a Corne, right?
WPM_ENABLE 			= yes # Enables the WPM (Words per minute) counter in the right OLED screen
TAP_DANCE_ENABLE    = yes

@fauxpark
Copy link
Member

If you're using RGBLight then this PR is not relevant.

@mtei
Copy link
Contributor Author

mtei commented Jul 16, 2021

I lost my rgb when I applied this tag. Should I make any modifications to my keymap?? I'm using RGBLIGHTS not RGB MATRIX

This PR change should not affect keyboards / keymaps with RGBLIGHT_ENABLE = yes set.

Are your keyboards and keymaps registered in this repository?
If so, please tell me the keyboard name and keymap name. I will try it.

@mtei mtei deleted the trim_rgblight.h_from_quantum.h branch July 16, 2021 18:19
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants