Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Quick hack to fix Astro65 board #13665

Merged
merged 2 commits into from
Jul 24, 2021
Merged

[Keyboard] Quick hack to fix Astro65 board #13665

merged 2 commits into from
Jul 24, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 23, 2021 •
edited
Loading

Description

Fix column num, and add NO_PIN until it can be properly fixed.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

  • Fix CI compiler

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member Author

drashna commented Jul 23, 2021

@swiftrax It looks like there is a missing pin here. Eg 16 columns, but 15 pins defined.

Do you know the correct pin layout for the board?

@drashna drashna requested a review from a team July 24, 2021 01:38
@swiftrax
Copy link
Contributor

E6, D5, D3, D4, D6, D7, B4, B5, B6, C6, C7, F6, F5, F4, F1, F0
@drashna

@drashna
Copy link
Member Author

drashna commented Jul 24, 2021

E6, D5, D3, D4, D6, D7, B4, B5, B6, C6, C7, F6, F5, F4, F1, F0
@drashna

Awesome, thanks! Updating the PR.

@drashna drashna merged commit 73d4d7d into qmk:develop Jul 24, 2021
@drashna drashna deleted the fix/keyboard_handwired_astra branch July 24, 2021 06:38
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 24, 2021
Merge remote-tracking branch 'qmk/develop' into develop
21ee150 
* qmk/develop: (33 commits)
  [Keyboard] Add Keychron Q1 (qmk#13397)
  [Keymap] add kinesis/keymaps/jwon (qmk#13618)
  [Keyboard] Dharma (qmk#13663)
  feature: Add swap hands support for sofle keyboard. (qmk#13654)
  Fix up xd002 rgb keymaps (qmk#13685)
  Avoid LTO conficts on arm_atsam (qmk#13676)
  [Keyboard] Reduce compile size for dz60rgb v2.1 (qmk#13680)
  [Keyboard] Fix type on pandora via keymap (qmk#13681)
  Remove deprecated callbacks for encoders and dip switches (qmk#13404)
  [Keyboard] Quick hack to fix Astro65 board (qmk#13665)
  [Keyboard] Added Compound keyboard support (qmk#12942)
  Disables rgblight twinkle by default. (qmk#13677)
  [Keyboard] Fix split matrix for sekigon grs 70ec (qmk#13672)
  [Keyboard] Fix matrix delay on Drop boards (qmk#13671)
  [Keyboard] Disable console by default on all Keebio boards (qmk#13649)
  CLI/Docs: Fix the format commands' name (qmk#13668)
  [Keyboard] Enable LTO by default on BastardKB Scylla (qmk#13664)
  [Keyboard] Fix symmetric70_proto build break on develop branch (qmk#13667)
  [Keyboard] Remove broken, unmaintained converter/ibm_5291 (qmk#13658)
  [Keyboard] Add model-v keyboard (qmk#13643)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
[Keyboard] Quick hack to fix Astro65 board (qmk#13665)
2b6e3a4 
* [Keyboard] Quick hack to fix Astro65 board

* Use proper pins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @swiftrax @fauxpark