Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy BACKLIGHT_CUSTOM_DRIVER option #13731

Merged
merged 1 commit into from
Jul 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions common_features.mk
Original file line number Diff line number Diff line change
Expand Up @@ -363,11 +363,6 @@ ifeq ($(strip $(LCD_ENABLE)), yes)
CIE1931_CURVE := yes
endif

# backward compat
ifeq ($(strip $(BACKLIGHT_CUSTOM_DRIVER)), yes)
BACKLIGHT_DRIVER := custom
endif

VALID_BACKLIGHT_TYPES := pwm timer software custom

BACKLIGHT_ENABLE ?= no
Expand Down
3 changes: 0 additions & 3 deletions keyboards/jj40/keymaps/oscillope/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ CONSOLE_ENABLE = no
COMMAND_ENABLE = yes

BACKLIGHT_ENABLE = no
BACKLIGHT_CUSTOM_DRIVER = no

RGBLIGHT_ENABLE = no
RGBLIGHT_CUSTOM_DRIVER = no

KEY_LOCK_ENABLE = yes
2 changes: 1 addition & 1 deletion keyboards/meira/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ UNICODE_ENABLE = no # Unicode
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
AUDIO_ENABLE = no # Audio output on port C6
RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight.
BACKLIGHT_CUSTOM_DRIVER = yes
BACKLIGHT_DRIVER = custom
BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality, also set ISSI_ENABLE below for Miera
ISSI_ENABLE = yes # If the I2C pullup resistors aren't install this must be disabled

Expand Down
2 changes: 1 addition & 1 deletion show_options.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ BUILD_OPTION_NAMES = \
HARDWARE_OPTION_NAMES = \
SLEEP_LED_ENABLE \
BACKLIGHT_ENABLE \
BACKLIGHT_CUSTOM_DRIVER \
BACKLIGHT_DRIVER \
RGBLIGHT_ENABLE \
RGBLIGHT_CUSTOM_DRIVER \
RGB_MATRIX_ENABLE \
Expand Down