-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some led drivers to common folder #13749
Conversation
I have thought (not very hard) about the logistics and worth of moving to a more traditional |
Ideally, I'd like to see the ISSI drivers in there too, but this is great. |
Done! Apologies in advance for the extra files that have to be reviewed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth putting the ISSI drivers into drivers/led/issi/
.
That hass been on the cards for the lifetime of this PR, and no one spoke up about it so i went with my personal preference. What i want to avoid is the "vendor" folder situation that happened with the other 2 drivers that I've moved. A folder with just 2 files inside it, which had been copied as some form of standard due to the precedence set with the issi folder. |
The ISSI drivers warrant their own directory due to the sheer number of them, whereas anything directly under |
I personally dont see the value, but if it helps get this across the line then i will make the change, Just a little disappointed that it was up for grabs and its only after ive made the change that i now have to do more work. |
I don't really see where you mentioned this. |
f257a33
to
7564eff
Compare
In the PR description. Doesnt matter anyway, ive moved the files keeping the issi folder. |
Wasn't really clear to me what you were saying there, the issi folder isn't a "parent folder that only contains 2 files" but I understand now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'm fine with throwing everything in /drivers/led
, since the naming helps sort them out. But either way is absolutely fine, IMO.
* Move some led drivers to common folder
* Move some led drivers to common folder
Description
Not 100% sold on the current "parent folder that only contains 2 files" paradigm. What I would like to see would be something like...
However it does at least have some value for
issi
right now due to the amount of tiles inc. led/rgb variant drivers.Types of Changes
Checklist