Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a toggle key for GUI On/Off in Magic feature #13830

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Add a toggle key for GUI On/Off in Magic feature #13830

merged 1 commit into from
Aug 17, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 1, 2021

Description

[Title]

Also, it's still july, right?

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 1, 2021 02:29
@zvecr zvecr requested a review from tzarc August 1, 2021 15:31
fauxpark
fauxpark reviewed Aug 1, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIA will not be able to add this to their selection, because it's placed after the Sequencer keycode range which is still potentially variable in length (#11156).

@drashna
Copy link
Member Author

drashna commented Aug 1, 2021

Yup, understood, but I also didn't want to change the order of the keycodes.

And in either way, there would need to be changes on via's end to support it anyhow. So figured it was safest to just put it at the end.

@drashna drashna force-pushed the magic/toggle_gui branch 2 times, most recently from caeab56 to 9a17c19 Compare August 8, 2021 04:35
@tzarc tzarc merged commit 4c4f632 into qmk:develop Aug 17, 2021
@drashna drashna deleted the magic/toggle_gui branch August 17, 2021 22:50
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Add a toggle key for GUI On/Off in Magic feature (qmk#13830)
c6fc1c7
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Add a toggle key for GUI On/Off in Magic feature (qmk#13830)
44decf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @tzarc @fauxpark @zvecr