-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix Key Override includes #13831
Conversation
b50cdac
to
964351f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather keep the includes the same, and just do the following,
diff --git a/quantum/process_keycode/process_key_override.c b/quantum/process_keycode/process_key_override.c
index 8b45a9404..09b272507 100644
--- a/quantum/process_keycode/process_key_override.c
+++ b/quantum/process_keycode/process_key_override.c
@@ -18,7 +18,7 @@
#include "quantum.h"
#include "report.h"
#include "timer.h"
-#include "process_key_override_private.h"
+#include "process_key_override.h"
#include <debug.h>
I can do so, but is there a specific reason for doing so? quantum.h contains all of other includes, and this does need a good number of includes. Also, just this would work too: #include "process_key_override.h"
#include "quantum.h" |
Including the bare minimum is general best practice, and things like quantum.h including the world produces many assumptions that are harder to unpick later. As the consumer of the api, why would you need to care about another enabled feature like maybe audio. |
* [BUG] Fix Key Override includes * simplify includes
* [BUG] Fix Key Override includes * simplify includes
Description
Include was wrong. Fixed.
Types of Changes
Issues Fixed or Closed by This PR
Checklist