Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pmw3360 code to only output debug info if mouse debugging is enabled #13993

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Fix pmw3360 code to only output debug info if mouse debugging is enabled #13993

merged 1 commit into from
Aug 13, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 13, 2021

Description

Debugging is good, but should only be reported when requested. This changes it so tha the pmw3360 sensor code only outputs debugging info if debug_mouse is set to true.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the bug label Aug 13, 2021
@drashna drashna requested a review from a team August 13, 2021 19:25
@github-actions github-actions bot added the core label Aug 13, 2021
@drashna drashna merged commit 7ef4d0c into qmk:develop Aug 13, 2021
@drashna drashna deleted the fix/pmw_debug_reporting branch August 13, 2021 21:20
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Aug 14, 2021
Merge remote-tracking branch 'qmk/develop' into develop
b520875 
* qmk/develop: (57 commits)
  [Keyboard] Add Irene Keyboard (qmk#13991)
  Fix `combo_disable` (qmk#13988)
  Fix Line endings in Absinthe VIA keymap (qmk#13997)
  [Keymap] clean up userspace, add XD75 / Keyboardio Atreus (qmk#13121)
  Crin Refactor (qmk#13982)
  Fix pmw3360 code to only output debug info if mouse debugging is enabled (qmk#13993)
  [Keyboard] Add Gud70 (qmk#12575)
  [Keyboard] Adding VIA to Absinthe (qmk#13031)
  [Keyboard] Macropad v2 polling rate fix (qmk#13129)
  [Keyboard] Add eniigmakeyboards/ek60 (qmk#13140)
  [Keyboard] Add n9 macropad (qmk#13168)
  [Keyboard] Updates to ScrabblePad (qmk#13177)
  [Keymap] adds sulrich crkbd (corne) personal keymap (qmk#13186)
  [Keymap] Updates to jdelkins userspace and keymaps (qmk#13216)
  [Keyboard] Add optional colemak layout to keymap (qmk#13217)
  [Keyboard] add support for alternate ortho UD40 PCB (qmk#13491)
  [Keyboard] Add split_3x5_3 layout support to boardsource/microdox (qmk#13323)
  [Keyboard] Interlace matrix scan for performance on Moonlander (qmk#13625)
  [Keybord] Add LS_60 keyboard (qmk#13851)
  [Keyboard] Add cest73/tkm keyboard (qmk#13939)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Fix pmw3360 code to only output debug info if mouse debugging is enab…
13050ec 
…led (qmk#13993)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Fix pmw3360 code to only output debug info if mouse debugging is enab…
3719314 
…led (qmk#13993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @fauxpark