Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layer mod keys to the list of keys disabled by NO_HAPTIC_MOD #14181

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Add layer mod keys to the list of keys disabled by NO_HAPTIC_MOD #14181

merged 1 commit into from
Oct 3, 2021

Conversation

purdeaandrei
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix -- I think this is a bugfix rather than a feature, since NO_HAPTIC_MOD should have always covered LM() keys too.
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@purdeaandrei
Copy link
Contributor Author

purdeaandrei commented Aug 26, 2021 •
edited
Loading

EDIT, doesn't depend on another pending PR anymore
Note that this PR depends on: (and currently also includes history of)
#14180

@purdeaandrei purdeaandrei changed the title F add layer mod keys to the list of keys disabled by no haptic mod Add layer mod keys to the list of keys disabled by no haptic mod Aug 26, 2021
@purdeaandrei purdeaandrei changed the title Add layer mod keys to the list of keys disabled by no haptic mod Add layer mod keys to the list of keys disabled by NO_HAPTIC_MOD Aug 26, 2021
@purdeaandrei purdeaandrei force-pushed the f_add_layer_mod_keys_to_the_list_of_keys_disabled_by_NO_HAPTIC_MOD branch from a58c78e to b62f6d7 Compare September 30, 2021 21:31
@purdeaandrei
Copy link
Contributor Author

Doesn't depend on pending PR anymore.
Now it's only a 2-line change.
Rebased to fix conflict.

@fauxpark fauxpark requested a review from a team September 30, 2021 21:34
@drashna drashna merged commit eb5b24f into qmk:develop Oct 3, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@purdeaandrei @ptrxyz
Add LM() keys to the list of keys disabled by NO_HAPTIC_MOD (qmk#14181)
0eeca6b
@purdeaandrei purdeaandrei deleted the f_add_layer_mod_keys_to_the_list_of_keys_disabled_by_NO_HAPTIC_MOD branch September 10, 2022 09:26
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@purdeaandrei
Add LM() keys to the list of keys disabled by NO_HAPTIC_MOD (qmk#14181)
c90c1e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purdeaandrei @drashna @fauxpark