Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bin/qmk #14231

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Remove bin/qmk #14231

merged 2 commits into from
Aug 29, 2021

Conversation

skullydazed
Copy link
Member

Description

It has been marked deprecated for several cycles, it's time to remove it.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the CI label Aug 29, 2021
@skullydazed skullydazed merged commit 596c4a1 into develop Aug 29, 2021
@drashna drashna deleted the remove_bin_qmk branch August 30, 2021 04:01
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Sep 2, 2021
* qmk/develop:
  Remove bin/qmk (qmk#14231)
  ensure that the directory for sys.executable is in the user's path (qmk#14229)
  move everything from qmkfm/base_container to qmkfm/qmk_cli (qmk#14230)
  Nyquist (qmk#14202)
  Update the nix-shell environment (qmk#13316)
  [Keyboard] Add Viktus SP Mini (qmk#14069)
  [Keyboard] Corrected layout for np24 by YMDK (qmk#14096)
  [Keymap] My Prime E keymap (qmk#14117)
  [Keyboard] Add kelownaRGB64 (qmk#14141)
  [Keyboard] fix compile error `make helix/rev2/sc:all` (qmk#14214)
  fix automatic directory for qmk lint (qmk#14215)
  Add check for non-assignment code in rules.mk (qmk#12108)
  remove qmk console, which is now part of the global cli (qmk#14206)
  Fixup upstream paths for submodules. (qmk#14205)
  Bootmagic lite docs clarity. (qmk#14204)
  add 'include keyboard_features.mk' into build_keyboard.mk (qmk#8422)
  2021Q3 pre-merge `develop` changelog, keyboard aliases (qmk#14198)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Remove the bin/qmk script

* remove bin/qmk from workflows
sigprof added a commit to sigprof/nix-devenv-qmk that referenced this pull request May 12, 2022
Apply changes made in the QMK `master` branch:

  * qmk/qmk_firmware#14231 (Remove bin/qmk)
  * qmk/qmk_firmware#16602 (Allow overriding Niv inputs in shell.nix)
sigprof added a commit to sigprof/nix-devenv-qmk that referenced this pull request May 12, 2022
sigprof added a commit to sigprof/nix-devenv-qmk that referenced this pull request May 12, 2022
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Remove the bin/qmk script

* remove bin/qmk from workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants