Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate STM32_EEPROM_ENABLE to use EEPROM_DRIVER #14433

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Migrate STM32_EEPROM_ENABLE to use EEPROM_DRIVER #14433

merged 2 commits into from
Sep 15, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 14, 2021 •
edited
Loading

Description

Avoids STM32_EEPROM_ENABLE becoming a template when adding new MCU support, while also making the API a little more uniform.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review September 14, 2021 03:14
@zvecr zvecr requested review from a team and tzarc September 14, 2021 23:11
@tzarc tzarc requested a review from a team September 15, 2021 02:16
@drashna drashna merged commit fa141a5 into qmk:develop Sep 15, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Migrate STM32_EEPROM_ENABLE to use EEPROM_DRIVER (qmk#14433)
a8c6498
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Migrate STM32_EEPROM_ENABLE to use EEPROM_DRIVER (qmk#14433)
99effc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core keyboard optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark