Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quantum: led: split out led_update_ports() for customization of led behaviour #14452

Merged
merged 3 commits into from
Oct 6, 2022
Merged

quantum: led: split out led_update_ports() for customization of led behaviour #14452

merged 3 commits into from
Oct 6, 2022

Commits on Aug 31, 2022

  1. quantum: led: split logic into dedicated function 

    Allow implementors of led_update_user() to modify the current led_state
but still use the default functionality for writing the state to the
respective PINs.
This can be used to reuse one of the standard LEDs for a different
usecase without having to reimplement all of that logic.

Fixes qmk#13272
    @t-8ch
    t-8ch committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    81b0365 View commit details
    Browse the repository at this point in the history

  2. quantum: led: simplify #ifdef-fery around available LEDs 

    The outer #ifdef only really protects the inversion of led_state.raw
which the compiler can easily optimize away if it is not needed.
    @t-8ch
    t-8ch committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a442442 View commit details
    Browse the repository at this point in the history

  3. quantum: led: mark led_update_ports as weak

    @t-8ch
    t-8ch committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    42fa8dd View commit details
    Browse the repository at this point in the history