compiledb: query include paths from gcc directly. #14462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Sep 16, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Sep 20, 2021
* qmk/develop: Remove backlight pin references in rules.mk (qmk#14513) compiledb: query include paths from gcc directly. (qmk#14462) [Keymap] blipson corne keymap (qmk#14469) Doc Fixes & Custom Matrix Fix (qmk#14526) [Keyboard] Add LeFishe Keyboard (qmk#14498) [Keymap] Added my own keymap for MIT Planck (qmk#14481) [Docs] fix wrong directory for RGB Matrix animations (qmk#14494) cKeys theDora Refactor (qmk#14495) [Keymap] Adding my Mun keymap. (qmk#14501) [Keymap] Updates to existing keymaps and userspace (qmk#14503) [Keyboard] Enabled Mousekeys by default on Boston (qmk#14507) [Keyboard] Change printf to dprintf (qmk#14510) [Keyboard] Enables I2C for OLKB rev*_drop boards (qmk#14514) [Keyboard] Quick fixes for the Mun to unblock customers (qmk#14505) [Keyboard] Fix Compiler issues for quick17 (qmk#14500) [Keyboard] Use old custom matrix for Drop Planck+Preonic (qmk#14488)
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
* Query include paths from gcc directly. * Change to -isystem * qmk format-python * tests
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Query include paths from gcc directly. * Change to -isystem * qmk format-python * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the logic of the compiledb generator to actually request from gcc the list of include directories it's going to use.
The original logic was injecting mingw32 directories for me -- this correctly handles the generation based on the toolchain in question.
Tested on both AVR and ARM.
Types of Changes
Checklist