Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ChibiOS-Contrib. #14547

Closed
wants to merge 1 commit into from
Closed

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Sep 21, 2021

Description

Updated ChibiOS-Contrib to pick up RP2040 USB support. Ping @hanya for confirmation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team September 21, 2021 21:49
@github-actions github-actions bot removed the core label Sep 21, 2021
@drashna drashna requested a review from a team September 21, 2021 21:57
@tzarc tzarc linked an issue Sep 21, 2021 that may be closed by this pull request
@drashna
Copy link
Member

drashna commented Sep 21, 2021

(Probably going to want a "convert to PR2040" option sometime after this)

@tzarc
Copy link
Member Author

tzarc commented Sep 21, 2021

For the SparkFun RP2040 ProMicro board? Yeah. On my radar. Got 4 of them handy already.
We'll need a ChibiOS upgrade first, anyway. Unsure we want the 21.6.x ChibiOS with the 20.3.x ChibiOS-Contrib, though.

@fauxpark
Copy link
Member

This also unblocks #14420, but I guess that's not as fun as the 2040 :P

@hanya
Copy link

hanya commented Sep 22, 2021

Current chibios @ 413e39c does not contain any RP2040 related changes yet.
So we have to update ChibiOS at the same time with the contrib.

I noticed recent ChibiOS migrated ChibiOS/os/common/ports/ARMCMx/* files into own directories.
The PORT_V in chibios.mk have to be updated to match to new directories.

@hanya
Copy link

hanya commented Sep 22, 2021

I found a bug in the usb driver for RP2040 in the contrib and made PR.

@KarlK90
Copy link
Member

KarlK90 commented Sep 22, 2021

Updated my RISC-V port for 21.6 as well in ChibiOS/ChibiOS-Contrib#302

@tzarc
Copy link
Member Author

tzarc commented Sep 22, 2021

Cancelling this for now. Will sort out the upgrade to 21.6.x with the existing in-flight PR for that upgrade.

@tzarc tzarc closed this Sep 22, 2021
@tzarc tzarc deleted the update_chibios-contrib branch September 22, 2021 21:20
@tzarc
Copy link
Member Author

tzarc commented Sep 22, 2021

#14208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for Raspberry Pi Pico
6 participants