Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mode SixtyFive M65HA and M65HI #14685

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Conversation

Gondolindrim
Copy link
Contributor

@Gondolindrim Gondolindrim commented Oct 3, 2021

This PR adds initial compatibility for Mode SixtyFive's M65HA and M65HI PCBs, respectively the ANSI and the ISO versions of its hotswap PCBs.

Both PCBs had two versions, a prototype (pre-Alpha) and a final run (Alpha); while the mass-production will ship with versions Alpha, pre-Alphas had a significant number of units made, hence their firmwares are listed for archiving purposes. Also release Alpha had matrix changes, hence why there are firmwares for both. Hence this PR adds four PCBs: M65HA pA and A, and M65HI pA and A.

Edit on december 1: the pre-alpha firmwares were removed for technical reasons later down the Pull Request.

The firmwares listed follow the conventions and suggestions by QMK reviewers in the soldered PCB revision (see #14027).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 3, 2021
@Gondolindrim Gondolindrim marked this pull request as ready for review October 3, 2021 23:38
keyboards/mode/m65ha_alpha/README.md Outdated Show resolved Hide resolved
keyboards/mode/m65ha_alpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65ha_alpha/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team October 21, 2021 04:09
keyboards/mode/m65hi_preAlpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65hi_preAlpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65hi_alpha/rules.mk Show resolved Hide resolved
keyboards/mode/m65hi_alpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65hi_preAlpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65ha_preAlpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65hi_alpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65ha_alpha/rules.mk Outdated Show resolved Hide resolved
keyboards/mode/m65ha_alpha/rules.mk Show resolved Hide resolved
keyboards/mode/m65ha_alpha/rules.mk Outdated Show resolved Hide resolved
@Gondolindrim
Copy link
Contributor Author

Added info.json for QMK Configurator (see Gondolindrim#1)

Thanks @itsjxck !

@Gondolindrim Gondolindrim requested a review from fauxpark October 31, 2021 17:59
@Jaicob
Copy link

Jaicob commented Nov 12, 2021

@fauxpark can you please give this PR another review or reassign someone who is available to?

@drashna drashna requested a review from a team November 16, 2021 00:29
@Gondolindrim
Copy link
Contributor Author

@fauxpark thanks for your patience -- I force-pushed the past commits to only include the M65H files.

@Gondolindrim
Copy link
Contributor Author

In talks with Mode we decided to keep the pre-alpha firmwares in our forks and just submit the alpha final production files, because the configurator files were not checking out.

@drashna drashna merged commit bd2e02b into qmk:master Dec 1, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
* qmk/develop: (76 commits)
  Update ReadMe for the Roopad (qmk#15380)
  Tidy up existing i2c_master implementations (qmk#15376)
  Remove pointless `CUSTOM_MATRIX = no` (qmk#15383)
  Remove manual enable of LTO within keyboards (qmk#15377)
  [Keyboard] Han60 QMK / VIA Support (qmk#15332)
  Convert ai03/orbit to SPLIT_KEYBOARD (qmk#15340)
  Convert not_so_minidox to SPLIT_KEYBOARD (qmk#15306)
  Tidy up `SLEEP_LED_ENABLE` rules (qmk#15362)
  [Keyboard] Add support for Mode SixtyFive M65HA and M65HI (qmk#14685)
  Implement MAGIC_TOGGLE_CONTROL_CAPSLOCK (qmk#15368)
  Rename Layout Macros for TKLs with F13 keys (qmk#15361)
  [Docs] Reorder functions in Understanding QMK (qmk#15357)
  [Keyboard] Fix up Endgame34 (qmk#15366)
  [Keyboard] Fix compilation issues for Ploopy Trackball classic (qmk#15364)
  [Keyboard] Add missng define for 4x6 Tractyl Manuform (qmk#15363)
  [Core] Added chconf.h for WB32 (qmk#15359)
  [Keyboard] kangaroo improvements (qmk#15350)
  [Keyboard] Convert ergoinu to SPLIT_KEYBOARD (qmk#15305)
  [Keymap] Keebio Sinc layout with macOS support (qmk#15324)
  Fixup paths for `ramonimbao/wete/v2`. (qmk#15360)
  ...
rudism pushed a commit to rudism/qmk_firmware that referenced this pull request Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants