Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up LCD_ENABLE/visualizer references #14855

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Tidy up LCD_ENABLE/visualizer references #14855

merged 3 commits into from
Oct 20, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 17, 2021 •
edited
Loading

Description

Recent changes make the LCD_ENABLE option redundant, same for the remaining visualizer references.

@dudeofawesome @drashna @belak @Choromanski, your keymaps were modified with minor changes.
@333fred and @narze, your keymaps contain additional failures which I can fix if required.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as draft October 17, 2021 20:34
@zvecr zvecr marked this pull request as ready for review October 17, 2021 20:44
@zvecr zvecr requested a review from a team October 17, 2021 20:44
@333fred
Copy link
Contributor

333fred commented Oct 18, 2021

@zvecr I created a PR to update my keymap to this branch (zvecr#21). I've left the existing color calls commented out in the code, those can be update and enabled when #10174 is merged.

@zvecr
Merge pull request #21 from 333fred/fix-ergodox-keymap
d727370 
Fix up my (333fred) ergodox keymap with new LCD driver
@zvecr zvecr merged commit 1816006 into qmk:develop Oct 20, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 21, 2021
Merge remote-tracking branch 'qmk/develop' into develop
2193c67 
* qmk/develop:
  Tidy up LCD_ENABLE/visualizer references (qmk#14855)
  Relocate PS2 code (qmk#14895)
  Rename platform SRC variable (qmk#14894)
  Align PS/2 GPIO defines (qmk#14745)
  Fix type of Tap Dance max index variable (qmk#14887)
  Make the MAGIC_TOGGLE_GUI keycode work (qmk#14886)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @333fred @ptrxyz
Tidy up LCD_ENABLE/visualizer references (qmk#14855)
14d94a3 
* Tidy up LCD_ENABLE/visualizer references

* Fix up my (333fred) ergodox keymap with new LCD driver

Co-authored-by: Fredric Silberberg <fred@silberberg.xyz>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr @333fred
Tidy up LCD_ENABLE/visualizer references (qmk#14855)
e765f6e 
* Tidy up LCD_ENABLE/visualizer references

* Fix up my (333fred) ergodox keymap with new LCD driver

Co-authored-by: Fredric Silberberg <fred@silberberg.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@belak belak belak left review comments

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zvecr @333fred @belak @drashna @fauxpark