Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move USE_CCACHE logic to common location #14899

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Move USE_CCACHE logic to common location #14899

merged 1 commit into from
Oct 21, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 21, 2021

Description

Pulled out from 13789, moved USE_CCACHE logic to common location so its not eventually duplicated to 4 places.

cc: @KarlK90

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 21, 2021 03:14
@github-actions github-actions bot added the core label Oct 21, 2021
@drashna drashna requested a review from a team October 21, 2021 04:04
@zvecr zvecr merged commit b36e0c6 into qmk:develop Oct 21, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 22, 2021
Merge remote-tracking branch 'qmk/develop' into develop
2c85296 
* qmk/develop:
  Fix right half of Nyquist in 4x12 mode having row shifted up by one (qmk#14914)
  Pteron36 Refactor (qmk#14904)
  Initial USB2422 driver (qmk#14835)
  Split out arm_atsam shift register logic (qmk#14848)
  Fix ccache default (qmk#14906)
  Move USE_CCACHE logic to common location (qmk#14899)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Move USE_CCACHE logic to common location (qmk#14899)
0770580
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Move USE_CCACHE logic to common location (qmk#14899)
897f804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @KarlK90