Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rip out old macro and action_function system #16025

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Rip out old macro and action_function system #16025

merged 2 commits into from
Jan 24, 2022

Conversation

fauxpark
Copy link
Member

Description

There are still a lot of action_get_macro()s in user keymaps, but the CI doesn't build them, so eh. They can be fixed up next cycle.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Jan 24, 2022
@fauxpark fauxpark requested a review from a team January 24, 2022 20:33
@github-actions github-actions bot removed the keyboard label Jan 24, 2022
@drashna drashna requested a review from a team January 24, 2022 20:56
zvecr
zvecr reviewed Jan 24, 2022
View reviewed changes
quantum/action_util.c Outdated Show resolved Hide resolved
@zvecr zvecr merged commit 1d11ae3 into qmk:develop Jan 24, 2022
@fauxpark fauxpark deleted the macro-action-fn-remove branch January 24, 2022 21:25
@zvecr zvecr mentioned this pull request Jan 25, 2022
Merged
14 tasks
@jpskenn jpskenn mentioned this pull request Apr 10, 2022
Closed
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request May 20, 2022
@jpskenn
DELETE: Removed system
42db9de 
qmk#16025
@weslord weslord mentioned this pull request Sep 21, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr