Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the keymap I have been using as a daily driver for the last month #16064

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Added the keymap I have been using as a daily driver for the last month #16064

merged 7 commits into from
Mar 10, 2022

Conversation

era1112
Copy link

@era1112 era1112 commented Jan 26, 2022

Adding the keymap I use as a daily driver for a community contribution.

This is being done since it was recommended in the guide at https://github.com/qmk/qmk_firmware/blob/master/docs/getting_started_github.md

Description

Added a keymap for a preonic rev3_drop, at /keyboards/preonic/keymaps/Era1112

Types of Changes

This keymap includes, and is a good source of code snippets for:

  • doubletap tapdance for caps lock
  • rotary encoder
  • macro record/playback
  • light on/off
  • sound on/off
  • blink-on-keypress w/ on/off keystroke
  • beep-on-keypress w/ on/off keystroke (althought this has runtime stability issues when typing fast, still trying to remediate)
  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jan 27, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the keymap folder to be all lower case.

@era1112
Copy link
Author

era1112 commented Jan 27, 2022

Please rename the keymap folder to be all lower case.

Changes made in latest commit (ab258f7)

@era1112 era1112 requested a review from drashna January 27, 2022 14:11
@drashna drashna requested a review from a team January 28, 2022 20:47
noroadsleft
noroadsleft approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 98da119 into qmk:master Mar 10, 2022
@noroadsleft
Copy link
Member

Thanks!

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@era1112 @zykrah
era1112 keymap for preonic (qmk#16064)
e0a95c9 
Added the keymap I have been using as a daily driver for the last month.

* good firmware 26 jan, best clicky mode stability so far

* modified to reflect master branch coding style

* further modified to reflect master branch coding style

* improving clicky stability, tuned down clicky delay duration

* changed name of keymap folder to use lowercase letters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@era1112 @noroadsleft @drashna