Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rgb-light and encoder for lily58 mod #16101

Merged
merged 6 commits into from
Mar 10, 2022
Merged

Add rgb-light and encoder for lily58 mod #16101

merged 6 commits into from
Mar 10, 2022

Conversation

LVladymyr
Copy link

@LVladymyr LVladymyr commented Jan 28, 2022 •
edited
Loading

Add rgb-light and encoders for lily58-glow-enc mod

Description

Set custom pins and settings for enabling rgb-light and encoders (one per controller).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename the folder and files to be all lower case.

keyboards/lily58/glowEnc/glowEnc.h Outdated Show resolved Hide resolved
keyboards/lily58/glowEnc/config.h Outdated Show resolved Hide resolved
LVladymyr and others added 2 commits January 28, 2022 22:15
@LVladymyr @drashna
Update keyboards/lily58/glowEnc/config.h
a920213 
Co-authored-by: Drashna Jaelre <drashna@live.com>
add GPL License to growEnc.h
5b62e9c
@drashna drashna requested a review from a team January 28, 2022 21:13
noroadsleft
noroadsleft approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit fc7a41f into qmk:master Mar 10, 2022
@noroadsleft
Copy link
Member

Thanks!

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@LVladymyr @zykrah
[Keyboard] lily58/glow_enc (qmk#16101)
45f2186 
Add rgb-light and encoder for lily58 mod

* add support for lily58 encoders (one per size) and rgb-light.

The pcb and details here https://github.com/orvisevans/Lily58-Glow-Enc

* add support for lily58 encoders (one per size) and rgb-light.

The pcb and details here https://github.com/orvisevans/Lily58-Glow-Enc

* Update keyboards/lily58/glowEnc/config.h

* add GPL License to growEnc.h

* rename folder according to requirement to lower case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LVladymyr @noroadsleft @drashna