[Core] Update mpaland/printf to eyalroz/printf fork #16163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlK90
force-pushed
the
feature/update-printf-library
branch
from
6a3ae4a
to
262f19c
Compare
|
Thank you for your contribution! |
|
Merge conflicts. |
|
Deferred to Q3 -- still marked as Draft, has conflicts. |
KarlK90
force-pushed
the
feature/update-printf-library
branch
from
262f19c
to
647539e
Compare
KarlK90
force-pushed
the
feature/update-printf-library
branch
2 times, most recently
from
b98aba8
to
158c31e
Compare
tzarc
approved these changes
Jul 7, 2022
mpaland printf implementation was abandoned in ~2019 and the fork by eyalroz is now regarded to be the goto replacement of it. So this commit incoporates the changes needed to use this fork in QMK. Note that pointer ptrdiff_t is always supported since commit 51c90f93a97fdaef895783ecbe24569be0db7cb8
KarlK90
force-pushed
the
feature/update-printf-library
branch
from
158c31e
to
2ae8344
Compare
14 tasks
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
mpaland printf implementation was abandoned in ~2019 and the fork by eyalroz is now regarded to be the goto replacement of it. So this commit incoporates the changes needed to use this fork in QMK. Note that pointer ptrdiff_t is always supported since commit 51c90f93a97fdaef895783ecbe24569be0db7cb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The currently used printf implementation by mpaland was abandoned in ~2019 and the fork by eyalroz is now regarded to be the goto replacement of it incorporating bug fixes and improvements (although I don't know if QMK is affected by these in any way) . So this commit incorporates the changes needed to use this fork in QMK.
As the
printffunctions now have proper format checking a workaround is needed for thebbinary format specifier, which wont be included until C2X in the official C standard - therefore will always throw a warning.Note that pointer
%t ptrdiff_tis always supported since eyalroz/printf@51c90f9Output
Types of Changes
Issues Fixed or Closed by This PR
Checklist