Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a build error if no bootloader is specified. #16181

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 3, 2022

Description

Some builds getting merged from master to develop don't include a BOOTLOADER in their rules.mk file -- bootmagic and the like don't work as a result. This flags any missing bootloader assignment as an error, preventing people flashing binaries that "aren't recoverable" without hardware intervention.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Feb 3, 2022
@tzarc tzarc requested review from fauxpark and a team February 3, 2022 05:10
@github-actions github-actions bot added the core label Feb 3, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
@tzarc tzarc merged commit 0be2eaf into qmk:develop Feb 3, 2022
@tzarc tzarc deleted the error-no-bootloader branch February 3, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants