Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix/pico move to split_common #16418

Merged
merged 8 commits into from
Feb 21, 2022
Merged

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Feb 21, 2022

Description

  • Abolished the custom matrix.c and split_util.c of helix/pico and changed to use split_common.
  • Organized helix/pico/post_rules.mk to minimize support with the HELIX = option.
  • Removed unused OLED code.

@MakotoKurauchi, This PR needs your review and approval.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna merged commit c204c73 into qmk:master Feb 21, 2022
@zvecr
Copy link
Member

zvecr commented Feb 22, 2022

@Biacco42 sorry this was missed, however you should have been pinged for review. Let us know if there are any issues with the change, and if you need any assistance on any merge rebase issues that have come from it.

@mtei mtei deleted the helixpico_move_to_split_common branch April 22, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants