Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk info: nicer rendering of ISO enter #16466

Merged
merged 7 commits into from
Mar 5, 2022
Merged

Conversation

fauxpark
Copy link
Member

Description

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 27, 2022 09:48
lib/python/qmk/keyboard.py Outdated Show resolved Hide resolved
@zvecr
Copy link
Member

zvecr commented Mar 5, 2022

$ qmk info -l -kb xd84
...
Layout Layout_75_Iso:
┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐
│Es││F1││F2││F3││F4││F5││F6││F7││F8││F9││F1││F1││F1││Pr││Pa││De│
└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──────┐┌──┐
│~ ││1 ││2 ││3 ││4 ││5 ││6 ││7 ││8 ││9 ││0 ││_ ││+ ││Backsp││Ho│
└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──────┘└──┘
┌────┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌────┐──┐
│Tab ││Q ││W ││E ││R ││T ││Y ││U ││I ││O ││P ││{ ││} ││Ente│Pa│
└────┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└┐   │──┘
┌─────┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐│   │┌──┐
│Caps ││A ││S ││D ││F ││G ││H ││J ││K ││L ││: ││@ ││~ ││   ││Pa│
└─────┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└───┘└──┘
┌───┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌─────┐┌──┐┌──┐
│Shi││| ││Z ││X ││C ││V ││B ││N ││M ││< ││> ││? ││Shift││Up││En│
└───┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└─────┘└──┘└──┘
┌───┐┌───┐┌───┐┌───────────────────────┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐
│Ctr││Win││Alt││Space                  ││Al││Fn││Ct││Le││Do││Ri│
└───┘└───┘└───┘└───────────────────────┘└──┘└──┘└──┘└──┘└──┘└──┘

Renders fine on configurator.

lib/python/qmk/keyboard.py Outdated Show resolved Hide resolved
Co-authored-by: Joel Challis <git@zvecr.com>
@zvecr zvecr merged commit 8e9d45d into qmk:master Mar 5, 2022
@fauxpark fauxpark deleted the info-key-render-iso branch March 5, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants