Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change helix:five_rows_jis keymap to use split_common #16538

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Mar 5, 2022

Description

  • Change helix:five_rows_jis keymap to use split_common
  • Makes QMK standerd OLED driver used by the helix:five_rows_jis keymap switchable.

@marksard, This PR needs to be tested and approved by you.

The Helix keyboard is currently in the process of changing from its original implementation of split_util to using split_common. (#16388)
As a first step, we are switching to split_common for each keymap one by one to make sure that each keymap is working properly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mtei added 2 commits March 5, 2022 19:16
… switchable.

* use TOP/drivers/oled/ssd1306_sh1106.c
  `make  helix:five_rows_jis`
  or
  `make OLED_SELECT=core  helix:five_rows_jis`
* use helix/local_drivers/ssd1306.c
  `make OLED_SELECT=local  helix:five_rows_jis`
@github-actions github-actions bot added the keymap label Mar 5, 2022
@mtei mtei requested a review from a team March 5, 2022 19:31
Copy link
Contributor

@marksard marksard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you m-tei san!

@drashna drashna merged commit 9d6cea0 into qmk:master Mar 7, 2022
@mtei mtei deleted the helix/split_common/five_rows_jis branch April 22, 2022 13:50
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants