Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing definition for non-encoder case. #16593

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Fix missing definition for non-encoder case. #16593

merged 3 commits into from
Mar 9, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Mar 9, 2022

Description

Fix compilation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 9, 2022 09:22
@tzarc tzarc force-pushed the fixup-dynamic-keymaps branch from de099c7 to dde0bfe Compare March 9, 2022 09:43
@tzarc tzarc changed the title Missing definition for non-encoder case. Fix missing definition for non-encoder case. Mar 9, 2022
@tzarc tzarc merged commit 5d67c4d into qmk:develop Mar 9, 2022
@tzarc tzarc deleted the fixup-dynamic-keymaps branch March 9, 2022 10:06
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Mar 23, 2022
@tzarc @waffle87
Fix missing definition for non-encoder case. (qmk#16593)
6f705ff
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@tzarc @zykrah
Fix missing definition for non-encoder case. (qmk#16593)
9d42d56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @drashna @KarlK90