Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix 'cd' subcommand on Windows #16610

Merged
merged 1 commit into from
Mar 10, 2022
Merged

CLI: Fix 'cd' subcommand on Windows #16610

merged 1 commit into from
Mar 10, 2022

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Mar 10, 2022 •
edited
Loading

Description

The cd subcommand was failing as the current shell's Windows path was
mangled while milc processed it.
Using subprocess directly avoids this issue and an extra layer of
subshell.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia
CLI: Fix 'cd' subcommand on Windows
82aae23 
The 'cd' subcommand was failing as the current shell's Windows path was
mangled while milc processed it.
Using 'subprocess' directly avoids this issue and an extra layer of
subshell.
@github-actions github-actions bot added cli qmk cli command python labels Mar 10, 2022
@zvecr zvecr added the bug label Mar 10, 2022
@zvecr zvecr merged commit b75f669 into qmk:master Mar 10, 2022
@Erovia Erovia deleted the cli/fix_win_cd branch March 11, 2022 18:29
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Erovia @zykrah
CLI: Fix 'cd' subcommand on Windows (qmk#16610)
3494806 
The 'cd' subcommand was failing as the current shell's Windows path was
mangled while milc processed it.
Using 'subprocess' directly avoids this issue and an extra layer of
subshell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erovia @zvecr