Added keyboard KPRepublic BM60V2EC #16866

LuisGit9 · 2022-04-17T03:50:24Z

Added support for the KPRepublic BM60 with Encoder, Revision 2 based on the code for the BM60HSRGB Rev 2

Description

Copied the kprepublic/bm60hsrgb directory and added support for the encoder as a button and rotation in both direction, assigning it as a mouse wheel and volumen control

Types of Changes

Core
Bugfix
New feature
Enhancement/optimization
[ x ] Keyboard (addition or update)
[ x ] Keymap/layout/userspace (addition or update)
Documentation

Issues Fixed or Closed by This PR

Checklist

[ x ] My code follows the code style of this project: C, Python
[ x ] I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
[ x ] I have read the CONTRIBUTING document.
I have added tests to cover my changes.
[ x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/kprepublic/bm60hsrgb_ec/rev2/keymaps/default/keymap.c

keyboards/kprepublic/bm60hsrgb_ec/rev2/rev2.c

keyboards/kprepublic/bm60hsrgb_ec/rev2/rules.mk

keyboards/kprepublic/bm60hsrgb_ec/readme.md

Co-authored-by: Drashna Jaelre <drashna@live.com>

…into bm60ec-rev2

LuisGit9

Some questions about two of the suggested changes.

Co-authored-by: Drashna Jaelre <drashna@live.com>

LuisGit9

Changes applied.

… confirmed code compiles

keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

LuisGit9

Accepted change.

keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h

Tested, accepted. Co-authored-by: Drashna Jaelre <drashna@live.com>

LuisGit9

Change accepted.

Didel · 2022-05-24T21:31:34Z

It looks like this PR is similar to (the older) #15104 . As #15104 adds both v1 and v2 support, I looks like it will add the same functionality as this PR with support for more revisions of the board...

github-actions · 2022-08-26T02:20:02Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboard-magpie

Changes to bring in line with current data driven status, and recent breaking changes

keyboard-magpie · 2022-08-31T19:06:50Z

keyboards/kprepublic/bm60hsrgb_ec/rev2/keymaps/default/keymap.c

+        KC_LCTL,   KC_LGUI,   KC_LALT,                       KC_SPC,                              KC_RALT, MO(1),   KC_LEFT, KC_DOWN, KC_RGHT
+    ),
+    [1] = LAYOUT_60_ansi_arrow(
+        _______, KC_F1,   KC_F2,   KC_F3,   KC_F4,   KC_F5,   KC_F6,   KC_F7,   KC_F8,   KC_F9,   KC_F10,  KC_F11,  KC_F12,  RESET,


Suggested change

_______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, RESET,

_______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, QK_BOOT,

keyboard-magpie · 2022-08-31T19:07:42Z

keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h

+#define VENDOR_ID       0x4B50
+#define PRODUCT_ID      0x1124
+#define DEVICE_VER      0x0002
+#define MANUFACTURER    KP Republic
+#define PRODUCT         BM60V2EC


Suggested change

#define VENDOR_ID 0x4B50

#define PRODUCT_ID 0x1124

#define DEVICE_VER 0x0002

#define MANUFACTURER KP Republic

#define PRODUCT BM60V2EC

keyboard-magpie · 2022-08-31T19:12:11Z

keyboards/kprepublic/bm60hsrgb_ec/rev2/info.json

+    "keyboard_name": "BM60V2EC",
+    "url": "https://kprepublic.com/products/bm60ec-bm60-ec-rgb-60-gh60-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-rgb-switch-type-c-rotary-knob",
+    "maintainer": "luisgit9",
+    "layouts": {


Suggested change

"layouts": {

"usb": {

"vid": "0x4B50",

"pid": "0x1124",

"device_version": "0.0.2"

},

"layouts": {

keyboard-magpie · 2022-08-31T19:13:45Z

keyboards/kprepublic/bm60hsrgb_ec/rev2/info.json

@@ -0,0 +1,79 @@
+{
+    "keyboard_name": "BM60V2EC",
+    "url": "https://kprepublic.com/products/bm60ec-bm60-ec-rgb-60-gh60-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-rgb-switch-type-c-rotary-knob",


Suggested change

"url": "https://kprepublic.com/products/bm60ec-bm60-ec-rgb-60-gh60-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-rgb-switch-type-c-rotary-knob",

"manufacturer": "kprepublic",

"url": "https://kprepublic.com/products/bm60ec-bm60-ec-rgb-60-gh60-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-rgb-switch-type-c-rotary-knob",

github-actions · 2022-10-17T02:18:07Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2022-11-17T02:14:15Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

LuisGit9 added 3 commits April 16, 2022 22:44

Added support for BM60EC/rev2 based on existing bm60rev2 support

cdb74f5

Turned Esc into tilde-Esc

8be299c

Added more information to the readme for the default layer

6c2595b

github-actions bot added keyboard keymap labels Apr 17, 2022

Fixed image link in readme.md for default keymap

3c3d97c

drashna requested changes Apr 18, 2022

View reviewed changes

keyboards/kprepublic/bm60hsrgb_ec/rev2/keymaps/default/keymap.c Outdated Show resolved Hide resolved

keyboards/kprepublic/bm60hsrgb_ec/rev2/rev2.c Show resolved Hide resolved

keyboards/kprepublic/bm60hsrgb_ec/rev2/rules.mk Outdated Show resolved Hide resolved

drashna reviewed Apr 18, 2022

View reviewed changes

keyboards/kprepublic/bm60hsrgb_ec/readme.md Show resolved Hide resolved

LuisGit9 and others added 3 commits April 18, 2022 10:52

Update keyboards/kprepublic/bm60hsrgb_ec/rev2/rules.mk

ad5ba92

Co-authored-by: Drashna Jaelre <drashna@live.com>

Added bootloader information in the readme.md files.

c380050

Merge branch 'bm60ec-rev2' of https://github.com/LuisGit9/qmk_firmware …

b6552b4

…into bm60ec-rev2

LuisGit9 commented Apr 18, 2022

View reviewed changes

LuisGit9 and others added 3 commits April 21, 2022 16:14

Update keyboards/kprepublic/bm60hsrgb_ec/rev2/keymaps/default/keymap.c

67c0f61

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/kprepublic/bm60hsrgb_ec/rev2/rev2.c

9b2d065

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/kprepublic/bm60hsrgb_ec/rev2/rev2.c

780d8b2

Co-authored-by: Drashna Jaelre <drashna@live.com>

LuisGit9 commented Apr 21, 2022

View reviewed changes

Applied changes to rev2.c twice, causing compilation error. Repaired,…

825f664

… confirmed code compiles

LuisGit9 requested a review from drashna April 22, 2022 01:11

drashna requested changes Apr 23, 2022

View reviewed changes

keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h Outdated Show resolved Hide resolved

Update keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h

6d66183

Co-authored-by: Drashna Jaelre <drashna@live.com>

LuisGit9 commented Apr 24, 2022

View reviewed changes

LuisGit9 requested a review from drashna April 24, 2022 00:25

drashna requested changes Apr 28, 2022

View reviewed changes

keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h Outdated Show resolved Hide resolved

Update keyboards/kprepublic/bm60hsrgb_ec/rev2/config.h

0c7e2ff

Tested, accepted. Co-authored-by: Drashna Jaelre <drashna@live.com>

LuisGit9 commented Apr 29, 2022

View reviewed changes

LuisGit9 requested a review from drashna April 29, 2022 01:16

drashna approved these changes Jul 11, 2022

View reviewed changes

drashna requested review from a team and drashna July 11, 2022 20:01

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 26, 2022

keyboard-magpie requested changes Aug 31, 2022

View reviewed changes

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Sep 1, 2022

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2022

github-actions bot closed this Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added keyboard KPRepublic BM60V2EC #16866

Added keyboard KPRepublic BM60V2EC #16866

LuisGit9 commented Apr 17, 2022 •

edited

Loading

LuisGit9 left a comment

LuisGit9 left a comment

LuisGit9 left a comment

LuisGit9 left a comment

Didel commented May 24, 2022

github-actions bot commented Aug 26, 2022

keyboard-magpie left a comment

keyboard-magpie Aug 31, 2022

keyboard-magpie Aug 31, 2022

keyboard-magpie Aug 31, 2022

keyboard-magpie Aug 31, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Nov 17, 2022

	_______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, RESET,
	_______, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, QK_BOOT,

-    "layouts": {
+       "usb": {
+              "vid": "0x4B50",
+              "pid": "0x1124",
+              "device_version": "0.0.2"
+         },
+       "layouts": {

	"url": "https://kprepublic.com/products/bm60ec-bm60-ec-rgb-60-gh60-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-rgb-switch-type-c-rotary-knob",
	"manufacturer": "kprepublic",
	"url": "https://kprepublic.com/products/bm60ec-bm60-ec-rgb-60-gh60-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-rgb-switch-type-c-rotary-knob",

Added keyboard KPRepublic BM60V2EC #16866

Added keyboard KPRepublic BM60V2EC #16866

Conversation

LuisGit9 commented Apr 17, 2022 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

LuisGit9 left a comment

Choose a reason for hiding this comment

LuisGit9 left a comment

Choose a reason for hiding this comment

LuisGit9 left a comment

Choose a reason for hiding this comment

LuisGit9 left a comment

Choose a reason for hiding this comment

Didel commented May 24, 2022

github-actions bot commented Aug 26, 2022

keyboard-magpie left a comment

Choose a reason for hiding this comment

keyboard-magpie Aug 31, 2022

Choose a reason for hiding this comment

keyboard-magpie Aug 31, 2022

Choose a reason for hiding this comment

keyboard-magpie Aug 31, 2022

Choose a reason for hiding this comment

keyboard-magpie Aug 31, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2022

github-actions bot commented Nov 17, 2022

LuisGit9 commented Apr 17, 2022 •

edited

Loading