[Keyboard] Fix compilation issues for Quark LP

[drashna]

Description

As title.

@npspears, would prefer that you checked off on this.

Types of Changes

• Bugfix
• Keyboard (addition or update)

Issues Fixed or Closed by This PR

• Tzarc CI:

  • RGB_MATRIX_DRIVER= is not a valid matrix type [ERRORS]

  builddefs/common_features.mk:341: *** Invalid RGB_MATRIX_DRIVER. Stop.

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[npspears]

#17008 (comment)

I think I know what's going on, but I want to check in with Jack tomorrow so I better know the error and how to correct it.

[drashna]

Well, to clarify, the first block (the "key matrix to led index" one), the LEDs are mapped to the matrix. Eg, if the first leds are on the bottom row, thenyou have it upside down. Eg:

  { 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47 }
  { 35, 34, 33, 32, 31, 30, 29, 28, 27, 26, 25, 24 },
  { 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23 },
  { 11, 10,  9,  8,  7,  6,  5,  4,  3,  2,  1,  0 },

And if you have LEDs at all the possible key positions ... eg, in between, then that gets more complicated. Eg:

  { 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 }
  { 38, 37, 36, 35, 34, 33, 32, 31, 30, 29, 28, 27 },
  { 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26 },
  { 14, 13, 12, 11, 10,  9,  7,  5,  3,  2,  1,  0 },

You'd also need to adjust the physical location block.

also the flag block should probably be:

   1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
   1, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 1,
   1, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 1,
   1, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 1

[drashna]

In fact, I'm just going to assume this is the case

[npspears]

The LEDs start at the top right corner and continue to the left, then down one row and continue to the right, and so forth. I suppose you could think of it like a snake

[npspears]

what else do you need from me to in order to see this pushed?

[drashna]

what else do you need from me to in order to see this pushed?

Mostly, I think it was waiting on confirmation of it working correctly, by you, I think. Which sounds like it has.

If you want, you can approve the PR, even if doesn't give it a green check mark.

The LEDs start at the top right corner and continue to the left, then down one row and continue to the right, and so forth. I suppose you could think of it like a snake

That's what I figured. That's the typical ws2812 method for routing the leds.